-
Notifications
You must be signed in to change notification settings - Fork 686
Update dialog headers to h2 instead of h4 #11154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates dialog headers in the Aspire Dashboard to use more semantically appropriate heading levels by changing from Typography.PaneHeader
(which renders as h4) to Typography.H2
for dialog titles.
- Changes dialog headers from h4 to h2 heading level for better semantic hierarchy
- Affects two dialog components that display titles to users
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
TextVisualizerDialog.razor | Updates dialog title typography from PaneHeader to H2 |
InteractionsInputDialog.razor | Updates dialog title typography from PaneHeader to H2 |
This PR changes the dialogs where we customize the header. What about dialogs that use the built in header template? They'll still be |
That will require changes in fluentui-blazor that I have to discuss with them about. This is a good start. The only urgent change we need is the ai assistant chat, but since we define custom headers in these two dialogs, we should also change their heading level. |
Actually, I think there could be a better fix for this. We could update markdown rendering so it doesn't output h2: xoofx/markdig#368 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer that we adjust markdown
We need to change the header levels. h4 is not appropriate for a modal title and is misleading. The markdown is not the issue! 😄 |
The current typo value is |
Description
PaneHeader seems like an appropriate typography for dialog headers, but it renders as an h4, which is too high of a heading number for the importance of the content. h2 is the appropriate level. No change in appearance
Before:

After:

Related: #10450
Checklist
<remarks />
and<code />
elements on your triple slash comments?doc-idea
templatebreaking-change
templatediagnostic
template