Add support for Azure Redis enterprise #10726

eerhardt · 2025-07-29T20:30:10Z

Description

This commit introduces a new Azure Redis Enterprise resource, enhancing the existing Redis functionality. Key changes include:

Introduced new Bicep modules for defining Azure Redis infrastructure.
Implemented extension methods in AzureRedisEnterpriseExtensions.cs for resource management.
Defined the Azure Redis Enterprise resource structure in AzureRedisEnterpriseResource.cs.

Fix #6831

Checklist

Is this feature complete?
- Yes. Ready to ship.
Are you including unit tests for the changes and scenario tests if relevant?
- Yes
Did you add public API?
- Yes
  - If yes, did you have an API Review for it?
    - No
  - Did you add <remarks /> and <code /> elements on your triple slash comments?
    - Yes
Does the change make any security assumptions or guarantees?
- No
Does the change require an update in our Aspire docs?
- Yes - [New article]: Add Azure Redis Enterprise article docs-aspire#4308

This commit introduces a new Azure Redis Enterprise resource, enhancing the existing Redis functionality. Key changes include: - Introduced new Bicep modules for defining Azure Redis infrastructure. - Implemented extension methods in `AzureRedisEnterpriseExtensions.cs` for resource management. - Defined the Azure Redis Enterprise resource structure in `AzureRedisEnterpriseResource.cs`. Fix dotnet#6831

Add tests Revert Redis playground app

Copilot

Pull Request Overview

This pull request adds support for Azure Redis Enterprise, providing an enterprise-grade alternative to the existing Azure Redis functionality. The implementation enables both Azure-hosted and container-based development scenarios with proper authentication and role assignment support.

Key changes include:

New Azure Redis Enterprise resource type with Bicep template generation
Extension methods for adding Redis Enterprise resources to the application model
Container fallback support for local development
Role assignment configuration for Azure identity-based access

Reviewed Changes

Copilot reviewed 23 out of 23 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
`src/Aspire.Hosting.Azure.Redis/AzureRedisEnterpriseResource.cs`	Core resource implementation with connection string, hostname, and password handling
`src/Aspire.Hosting.Azure.Redis/AzureRedisEnterpriseExtensions.cs`	Extension methods for adding Redis Enterprise resources and container fallback
`tests/Aspire.Hosting.Azure.Tests/AzureRedisEnterpriseExtensionsTests.cs`	Comprehensive test coverage for the new functionality
`playground/` files	Updated playground examples demonstrating Redis Enterprise usage
Multiple snapshot files	Generated Bicep templates and test verification files

playground/Redis/Redis.ApiService/Redis.ApiService.csproj

src/Aspire.Hosting.Azure.Redis/AzureRedisEnterpriseExtensions.cs

playground/cdk/CdkSample.AppHost/Program.cs

davidfowl · 2025-08-28T04:50:22Z

Where's the equivalent of WithAccessKeyAuthentication?

eerhardt · 2025-08-28T13:22:37Z

Where's the equivalent of WithAccessKeyAuthentication?

I'm wondering whether we need it or not. We don't support password/key auth for normal Azure resources, including SQL Server.

The original 3 database ones (Redis, CosmosDB, and PostgreSQL) had access key / password because that's all we knew how to do at the time. It took us a few versions to figure out how to support Entra auth.

So I think we leave WithAccessKeyAuthentication off until it is proven we need it.

davidfowl · 2025-09-01T23:41:35Z

Redis and Postgres are special because they can work with compute that does not support azure natively (e.g keycloak). Sometimes client libs are updated to handle native azure RBAC but the ones that don't require username and password (or keys).

github-actions · 2025-09-02T07:40:55Z

🚀 Dogfood this PR with:

curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 10726

Or

Run remotely in PowerShell:

iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 10726"

1. Make Azure Redis Enterprise experimental for its initial release 2. Support WithAccessKeyAuthentication

eerhardt · 2025-09-02T19:36:39Z

Ok, I've responded to all existing feedback. Please take another look.

davidfowl · 2025-09-03T07:22:32Z

Tested and it works! (with key auth because I couldn't figure out azure redis rbac, #11141).

azd does not yet understand redis enterprise resources:

cc @vhvb1989

davidfowl · 2025-09-03T07:24:56Z

src/Aspire.Hosting.Azure.Redis/AzureRedisEnterpriseExtensions.cs

+        {
+            infrastructure.Add(new ProvisioningOutput("connectionString", typeof(string))
+            {
+                Value = BicepFunction.Interpolate($"{redis.HostName}:10000,ssl=true")


10000 is the port number? Why?

This was the suggestion from @CawaMS and team. And it is the value when I create one through the portal.

davidfowl

Few questions but 👍🏾

eerhardt · 2025-09-03T13:36:44Z

(with key auth because I couldn't figure out azure redis rbac, #11141).

See https://learn.microsoft.com/en-us/dotnet/aspire/caching/azure-cache-for-redis-integration?tabs=dotnet-cli#add-azure-cache-for-redis-authenticated-client for instructions how to do it until we have a client integration for it.

azd does not yet understand redis enterprise resources:

Looks like https://github.com/Azure/azure-dev/blob/a9a799fcecb24305bdf57298453574e3b0ac9622/cli/azd/pkg/azapi/azure_resource_types.go#L54-L96 needs to be updated.

vhvb1989 · 2025-09-03T17:24:01Z

Tested and it works! (with key auth because I couldn't figure out azure redis rbac, #11141).

azd does not yet understand redis enterprise resources:
cc @vhvb1989

See: #11244 - I created a PR for you.

davidfowl · 2025-09-03T17:42:10Z

now assign copilot 😄

vhvb1989 · 2025-09-03T17:48:22Z

now assign copilot 😄

I did, but locally (VSCode + GHCP). I've been liking that one better than iterating in the PR.

github-actions bot added the area-integrations Issues pertaining to Aspire Integrations packages label Jul 29, 2025

eerhardt force-pushed the AddRedisEnterprise branch from 1a82dc3 to d8f5be3 Compare August 25, 2025 19:15

Fill out the rest of the Redis Enterprise

5477335

Add tests Revert Redis playground app

eerhardt marked this pull request as ready for review August 25, 2025 21:10

Copilot AI review requested due to automatic review settings August 25, 2025 21:10

Copilot AI reviewed Aug 25, 2025

View reviewed changes

playground/Redis/Redis.ApiService/Redis.ApiService.csproj Outdated Show resolved Hide resolved

eerhardt mentioned this pull request Aug 25, 2025

[New article]: Add Azure Redis Enterprise article dotnet/docs-aspire#4308

Open

Revert more playground changes

a50f13f

eerhardt requested a review from sebastienros August 25, 2025 21:25

eerhardt commented Aug 25, 2025

View reviewed changes

src/Aspire.Hosting.Azure.Redis/AzureRedisEnterpriseExtensions.cs Show resolved Hide resolved

davidfowl reviewed Aug 28, 2025

View reviewed changes

playground/cdk/CdkSample.AppHost/Program.cs Show resolved Hide resolved

davidfowl closed this Sep 2, 2025

davidfowl reopened this Sep 2, 2025

dotnet-policy-service bot added this to the 9.5 milestone Sep 2, 2025

Respond to PR feedback

7dbd23f

1. Make Azure Redis Enterprise experimental for its initial release 2. Support WithAccessKeyAuthentication

Update to stable Provisioning version

dd94c1a

davidfowl reviewed Sep 3, 2025

View reviewed changes

davidfowl approved these changes Sep 3, 2025

View reviewed changes

vhvb1989 mentioned this pull request Sep 3, 2025

Tested and it works! (with key auth because I couldn't figure out azure redis rbac, https://github.com/dotnet/aspire/pull/11141). #11244

Closed

davidfowl merged commit 2237f18 into dotnet:main Sep 3, 2025
299 checks passed

Add support for Azure Redis enterprise #10726

Add support for Azure Redis enterprise #10726

Uh oh!

Conversation

eerhardt commented Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

davidfowl commented Aug 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eerhardt commented Aug 28, 2025

Uh oh!

davidfowl commented Sep 1, 2025

Uh oh!

github-actions bot commented Sep 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eerhardt commented Sep 2, 2025

Uh oh!

davidfowl commented Sep 3, 2025

Uh oh!

davidfowl Sep 3, 2025

Choose a reason for hiding this comment

Uh oh!

eerhardt Sep 3, 2025

Choose a reason for hiding this comment

Uh oh!

davidfowl Sep 3, 2025

Choose a reason for hiding this comment

Uh oh!

davidfowl left a comment

Choose a reason for hiding this comment

Uh oh!

eerhardt commented Sep 3, 2025

Uh oh!

vhvb1989 commented Sep 3, 2025

Uh oh!

Uh oh!

davidfowl commented Sep 3, 2025

Uh oh!

vhvb1989 commented Sep 3, 2025

Uh oh!

Uh oh!

eerhardt commented Jul 29, 2025 •

edited

Loading

davidfowl commented Aug 28, 2025 •

edited

Loading

github-actions bot commented Sep 2, 2025 •

edited

Loading