Skip to content

Include .NET 10 global install in copilot setup steps #10577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2025

Conversation

danmoseley
Copy link
Member

@danmoseley danmoseley commented Jul 21, 2025

Description

Install .NET 10 globally in the copilot setup steps. It's not required for build, but it is required for (at least) the NuGet MCP server, which I plan to enable. This change adds less than 10 seconds to the 1 minute setup.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

@Copilot Copilot AI review requested due to automatic review settings July 21, 2025 23:14
@danmoseley danmoseley added the area-engineering-systems infrastructure helix infra engineering repo stuff label Jul 21, 2025
@danmoseley danmoseley requested review from radical and removed request for Copilot July 21, 2025 23:15
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds .NET 10 installation to the GitHub Actions workflow for Copilot setup to support MCP servers (specifically the NuGet MCP server). The change ensures that .NET 10 is globally available during Copilot operations while maintaining the existing build requirements.

Key Changes:

  • Adds .NET 10.x preview installation step to the Copilot setup workflow
  • Includes a diagnostic step to log .NET installation information

@radical
Copy link
Member

radical commented Jul 21, 2025

The restore step should be installing it. Maybe we need to add ${{ github.workspace }}/.dotnet to $GITHUB_PATH?

@danmoseley danmoseley marked this pull request as draft July 22, 2025 21:57
@danmoseley danmoseley marked this pull request as ready for review July 22, 2025 22:32
@danmoseley danmoseley enabled auto-merge (squash) July 22, 2025 22:34
@danmoseley
Copy link
Member Author

as discussed offline, 'dotnet.sh' puts down P5 for its local install at the moment, which is too old, but more importantly doesn't seem to put it on the path. we can investigate later.

@danmoseley danmoseley merged commit 5223e6e into dotnet:main Jul 22, 2025
273 of 274 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-engineering-systems infrastructure helix infra engineering repo stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants