Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for process to exit if killed #15545

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Conversation

ellahathaway
Copy link
Member

@ellahathaway ellahathaway commented Feb 18, 2025

Related to #15510
Related to dotnet/dnceng#4798

After killing the process, the exit status cannot be checked until the process exits. This needs to be fixed because it is causing an exception to be thrown, resulting in the logs not being written to.

@ellahathaway ellahathaway requested a review from a team February 18, 2025 20:01
Copy link
Member

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems straightforward to me 😀

:shipit:

@ellahathaway ellahathaway merged commit 2916656 into dotnet:main Feb 18, 2025
11 checks passed
@ellahathaway ellahathaway deleted the mac-timeout branch February 18, 2025 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants