Skip to content

Add missing accumulate argument for index_put_ method #1460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Mar 27, 2025

Conversation

alinpahontu2912
Copy link
Member

Fixes #1374

ozanMSFT
ozanMSFT previously approved these changes Mar 19, 2025
Copy link
Contributor

@ozanMSFT ozanMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks for also adding additional unit tests to cover the scenario as we've discussed before.

I left one nice to have suggestion comment.

Copy link
Contributor

@ozanMSFT ozanMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ozanMSFT ozanMSFT merged commit 3701fc5 into dotnet:main Mar 27, 2025
2 checks passed
@alinpahontu2912 alinpahontu2912 deleted the index_put_fix branch August 9, 2025 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add accumulate to index_put_
2 participants