Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing accumulate argument for index_put_ method #1460

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Add missing accumulate argument for index_put_ method #1460

wants to merge 13 commits into from

Conversation

alinpahontu2912
Copy link
Member

Fixes #1374

ozanMSFT
ozanMSFT previously approved these changes Mar 19, 2025
View reviewed changes
Copy link
Contributor

@ozanMSFT ozanMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks for also adding additional unit tests to cover the scenario as we've discussed before.

I left one nice to have suggestion comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozanMSFT ozanMSFT Awaiting requested review from ozanMSFT

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add accumulate to index_put_
2 participants
@alinpahontu2912 @ozanMSFT