Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.NET8 upgrade #1452

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

.NET8 upgrade #1452

wants to merge 9 commits into from
+63 −57

Conversation

alinpahontu2912
Copy link
Member

Upgrade build from target framework .Net6 to .Net8

@alinpahontu2912 alinpahontu2912 changed the title WIP - .NET8 upgrade .NET8 upgrade Mar 4, 2025
@alinpahontu2912 alinpahontu2912 marked this pull request as ready for review March 4, 2025 13:11
@alinpahontu2912
Copy link
Member Author

Packages relying on TorchSharp:
DiffSharp: deprecated: https://www.nuget.org/packages?q=diffsharp
Microsoft.ML.TorchSharp: https://www.nuget.org/packages/Microsoft.ML.TorchSharp/, uses .NETStandard 2, so should be compatible with this upgrade

@alinpahontu2912 alinpahontu2912 requested a review from ozanMSFT March 5, 2025 13:02
@alinpahontu2912
Merge branch 'dotnet:main' into net8_migration

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
e7e07ea
@alinpahontu2912
update release notes

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
0674edc
@alinpahontu2912
update package to fix security vulnerability

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
b478506
@alinpahontu2912
Copy link
Member Author

alinpahontu2912 commented Mar 19, 2025 •
edited
Loading

Will revert last commit ( upgrade ImageSharp package version https://www.nuget.org/packages/SixLabors.ImageSharp#versions-body-tab ) and put in a diferent PR, with extra releasenote update. Build started failing and it was because Azure pipelines refused to use a vulnerable package to build. Similar thing happened before:

TorchSharp/RELEASENOTES.md

Line 288 in 5ba1402

Update to SkiaSharp 2.88.6 to avoid the libwebp vulnerability.<br/>

ozanMSFT
ozanMSFT requested changes Mar 19, 2025
View reviewed changes
Copy link
Contributor

@ozanMSFT ozanMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for some additional local tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozanMSFT ozanMSFT

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alinpahontu2912 @ozanMSFT