fix: Deadlock issue when invoked external command write a lot of output #2877
+46
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filzrev
changed the title
adamsitnik
reviewed
Nov 27, 2025
Member
adamsitnik
left a comment
adamsitnik
left a comment
There was a problem hiding this comment.
We could use the existing helper for that, but it's not a must have.
BTW I was just assigned a week ago to redesign those APIs and make sure .NET users don't run into such deadlocks. And I am going to use this PR as one example of a bug in popular and mature OSS lib.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intended to fix #2873
1.
DotNetSdkValidator.csModify code to call ReadToEnd before WaitForExit.
2.
ProcessHelper.csRemove
RedirectStandardError = truesetting because stderror is not consumed.3.
ProcessExtensions.csModify code to asynchronously read StandardOutput to support timeout. (ReadToEnd don't support timeout)
And change code to use KillTree when timeout happens. (It might wait 30 seconds if kill signal is not property handled though)