-
-
Notifications
You must be signed in to change notification settings - Fork 1k
deps: Update package dependencies #2750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: Update package dependencies #2750
Conversation
c0596bb
to
10e69fd
Compare
10e69fd
to
c57ad52
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @filzrev !
foreach (var version in targetVersions) | ||
{ | ||
AddJob(baseJob.WithNuGet("Newtonsoft.Json", version) | ||
.WithCustomBuildConfiguration(version) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was the WithCustomBuildConfiguration
change required to get it to work? If so, why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed WithCustomBuildConfiguration
setting on latest commit.
When I've tested on v0.14.0 based code previously. wrong DLL version are placed on benchmarks bin directory.
But it seems not needed with latest code (that using ArtifactsPath
for benchmark project build)
</ItemGroup> | ||
<ItemGroup Condition=" '$(TargetFramework)' == 'netstandard2.0' "> | ||
<PackageReference Include="Microsoft.Win32.Registry" Version="5.0.0" /> | ||
<!-- Reference System.Numerics.Vectors 4.5.0 (that support net461) as minimum version to avoid MSB3277 warning --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding the comment 👍
This PR update package dependencies to latest versions.
How to confirms outdated packages
Run following command.
List of updated packages
FSharp.Core
4.6.0
9.0.300
Iced
1.17.0
1.21.0
JetBrains.Profiler.SelfApi
2.5.11
2.5.13
Microsoft.CodeAnalysis.CSharp
4.12.0
4.14.0
Microsoft.Diagnostics.Runtime
1.1.126102
3.1.512801
Microsoft.Diagnostics.Tracing.TraceEvent
3.1.8
3.1.21
Microsoft.NETCore.Platforms
6.0.0
7.0.4
Microsoft.NETFramework.ReferenceAssemblies
1.0.2
1.0.3
Microsoft.NET.Test.Sdk
17.7.2
[17.13.0]
Microsoft.VisualStudio.DiagnosticsHub.BenchmarkDotNetDiagnosers
17.13.35606.1
18.0.36127.1
Newtonsoft.Json
13.0.1
[13.0.1]
ScottPlot
5.0.54
5.0.55
System.Configuration.ConfigurationManager
4.5.0
9.0.5
System.Drawing.Common
4.7.2
9.0.5
System.Management
6.0.0
9.0.5
System.Memory
4.5.5
4.6.3
System.Runtime.CompilerServices.Unsafe
6.0.0
6.1.2
System.Threading.Tasks.Extensions
4.5.4
4.6.3
System.ValueType
4.5.0
4.6.1
Verify.Xunit
20.8.2
30.3.1
xunit
2.9.2
2.9.3
xunit.runner.visualstudio
2.4.1
[2.8.2]
Note
BenchmarkDotNet.IntegrationTests.ManualRunning.MultipleFrameworks
project contains legacy targets (.NET461
andnetcoreapp2.0
) So it need to usexunit.runner.visualstudio
v2.4.1 that compatible these frameworks.Microsoft.NET.Test.Sdk
14.0.0 or later depends on NewtonsoftJson13.0.3
. So it can't update versionsSystem.Numerics.Vectors
fornetstandard2.0
build need to reference4.5.0
version (that support net461).Other changes
1.
BenchmarkDotNet.Samples.csproj
IntroNativeMemory.cs
Add custom benchmark filter (
WindowsOnlyAttribute
) to exclude benchmarks that not works on non-Windows OS.(Because
System.Drawing.Common
is not supported .NET 6.0 or later)IntroNuGet.cs
Modify benchmarks to use Newtonsoft.Json
13.0.1
as baseline package.And add
WithCustomBuildConfiguration
settings. (It's required when targeting multiple NuGet versions)2.
BenchmarkDotNet.IntegrationTests.ManualRunning.MultipleFrameworks.csproj
NU1901
/NU1902
/NU1904
.3. Remove
[UsesVerify]
attributesThis attribute is removed on latest
xUnit.Verify
package.Additional manual tests
IntroNuGet
/IntroVisualStudioProfiler
benchmark behaviorsBenchmarkDotNet.IntegrationTests.ManualRunning
tests behaviors. (Blocked by Some of the tests defined in theBenchmarkDotNet.IntegrationTests.ManualRunning
project failed to run #2751)BenchmarkDotNet.IntegrationTests.ManualRunning.MultipleFrameworks
tests behaviors.