Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Pre3] Response streaming default and opt-out #34894

Merged
merged 11 commits into from
Mar 25, 2025
Merged

[Pre3] Response streaming default and opt-out #34894

merged 11 commits into from
Mar 25, 2025

Conversation

guardrex
Copy link
Collaborator

@guardrex guardrex commented Mar 5, 2025 •
edited by github-actions bot
Loading

Fixes #34870
Addresses #34948

Notes

  • Adds a bit to the existing coverage to include HttpCompletionOption.ResponseHeadersRead.
  • Versions in the new coverage for >=10.0.

cc: @campersau

Internal previews

📄 File 🔗 Preview link
aspnetcore/blazor/call-web-api.md aspnetcore/blazor/call-web-api

@guardrex guardrex self-assigned this Mar 5, 2025
@guardrex guardrex mentioned this pull request Mar 5, 2025
Open
@guardrex guardrex requested a review from pavelsavara March 5, 2025 17:42
@guardrex guardrex mentioned this pull request Mar 5, 2025
Closed
@guardrex
Copy link
Collaborator Author

guardrex commented Mar 5, 2025 •
edited
Loading

@campersau ... In the opt-out case, is ResponseContentRead still the default for HttpCompletionOption? ... and if so, then we don't need to remark on that in the >=10.0 coverage, correct?

@guardrex
Copy link
Collaborator Author

guardrex commented Mar 5, 2025

... and this is for Preview 2, correct?

@guardrex guardrex closed this Mar 5, 2025
@guardrex guardrex reopened this Mar 5, 2025
@guardrex guardrex mentioned this pull request Mar 6, 2025
Closed
@pavelsavara
Copy link
Member

Please confirm that this is for Preview 2.

Probably preview3, but it's not done yet.

@guardrex guardrex changed the title Response streaming default and opt-out [Pre3] Response streaming default and opt-out Mar 6, 2025
@guardrex guardrex mentioned this pull request Mar 12, 2025
Open
@guardrex
Copy link
Collaborator Author

@pavelsavara @campersau ... I think my latest updates to this PR cover everything. Can one or both of you make a final check? ... and please confirm that this is still going to make it for Pre3 (if not, I'll mark it for Pre4).

pavelsavara
pavelsavara approved these changes Mar 25, 2025
View reviewed changes
aspnetcore/blazor/call-web-api.md
* Add the `<WasmEnableStreamingResponse>` property to the project file with a value of `false`:

```xml
<WasmEnableStreamingResponse>false</WasmEnableStreamingResponse>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would not work for Blazor until dotnet/runtime#97449 is fixed. I don't think we need to worry about it in the preview docs.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dan would like the preview docs accurate for a given preview release.

I'll comment out just the <WasmEnableStreamingResponse> description until later, and I'll track on that issue to surface it.

@pavelsavara
Copy link
Member

this is still going to make it for Pre3

Yes

@guardrex guardrex merged commit d217293 into main Mar 25, 2025
3 checks passed
@guardrex guardrex deleted the guardrex/blazor-opt-out-response-streaming branch March 25, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelsavara pavelsavara pavelsavara approved these changes

@campersau campersau campersau approved these changes

Assignees

@guardrex guardrex

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Response streaming opt-out
3 participants
@guardrex @pavelsavara @campersau