Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Blazor enhanced nav events #34101

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Conversation

guardrex
Copy link
Collaborator

@guardrex guardrex commented Nov 13, 2024

Fixes #34086
Addresses #31909

Per dotnet/aspnetcore#58630.

They seem straightforward enough. I didn't see tests for the new events in the framework. Do you have any specific example(s) that you'd like to show for them?

Also, I'm not sure if using the word "load" in the way that I have for the description is correct for enhancedload. 👀


Internal previews

📄 File 🔗 Preview link
aspnetcore/blazor/javascript-interoperability/static-server-rendering.md aspnetcore/blazor/javascript-interoperability/static-server-rendering

@guardrex guardrex merged commit a7125f7 into main Dec 2, 2024
3 checks passed
@guardrex guardrex deleted the guardrex/blazor-enhanced-nav-events branch December 2, 2024 21:47
@MackinnonBuck
Copy link
Member

Sorry, I should have commented first, then approved. My bad!

@MackinnonBuck
Copy link
Member

They seem straightforward enough. I didn't see tests for the new events in the framework. Do you have any specific example(s) that you'd like to show for them?

Not in particular - I think it's enough to call out that they exist. I actually added them because we had a need for them in the framework itself.

@guardrex
Copy link
Collaborator Author

guardrex commented Dec 2, 2024

I'll submit a patch, but I'm on the treadmill running off a lot of 🦃🦃🦃🦃😆. I'll update this by EOD before it goes live.

UPDATE: Patched on #34262.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blazor enhancednavigationstart and enhancednavigationend events
2 participants