⚙️ FEATURE-#36: Share MCP servers with pycodeloop's native saved: registry - #37
Merged
Conversation
FernandoCelmer
commented
Aug 16, 2026
FernandoCelmer
left a comment
Member
Author
There was a problem hiding this comment.
Code Review
Code issues found: 4
| # | Severity | Issue |
|---|---|---|
| 1 | [Blocking] | Sync I/O blocks extension host |
| 2 | [Blocking] | writeConfig — silent data loss on write failure |
| 3 | [Blocking] | saveMcpServer silently overwrites existing entries |
| 4 | [Blocking] | Registry name not validated — colon/space breaks saved: token |
Member
Author
Code Review SummaryCode issues found: 4
|
FernandoCelmer
commented
Aug 16, 2026
FernandoCelmer
left a comment
Member
Author
There was a problem hiding this comment.
Automated review — 3 blocking issues found (scores 75–90). See inline comments.
Keep both maybeSaveToRegistry (feature/36) and toggleWorkspace (master) in settings.controller.ts — methods were added at the same insertion point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
src/services/mcpRegistry.service.ts— New service that reads/writes~/.pycodeloop/config.json'smcp_serverssection directly (same shape as pycodeloop'sMCPServerRegistry), preserving every other top-level key. ExportssplitCommand()(tokenizes a raw launch command intocommand/args, mirroringshlex.split()on the CLI side),saveMcpServer(),listSavedMcpServers(), anddeleteSavedMcpServer().src/features/settings/settings.controller.ts—manageMcpServers()'s add flow now callsmaybeSaveToRegistry()before writing to VS Code settings. If the user opts in, the server is written to the shared pycodeloop registry andpycodeloop.mcpServersstoressaved:<name>instead of the raw command string. Declining the prompt keeps the existing raw-command behavior unchanged.test/mcpRegistry.service.test.ts— Unit tests coveringsplitCommandtokenizing: bare command, positional args, single/double-quoted segments, extra whitespace.Motivation and Context
pycodeloop/mcp.py'sMCPServerRegistrypersists named MCP server configs so the CLI can reference one as--mcp saved:<name>, meant to be shared between the interactive CLI andserve. The plugin reimplemented its own MCP list entirely inside VS Code settings, never touching that registry — a user running both the extension andpycodeloop chat/runin a terminal had to configure the same servers twice. This is an additive change; declining the prompt keeps prior behavior exactly.Closes #36.
Types of changes
Checklist