🪲 BUG-#32: Custom model silently reverted to defaultModel on every provider - #33
Merged
Conversation
FernandoCelmer
commented
Aug 16, 2026
FernandoCelmer
left a comment
Member
Author
There was a problem hiding this comment.
Two blocking issues found in the model validation logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
src/features/settings/settings.controller.ts—storedModelFor()andhealStaleModel()no longer treat "not indef.models" as stale.def.modelsis a curated shortlist for the QuickPick menu, not an exhaustive whitelist — local providers (Ollama, LM Studio) in particular have open-ended model names.healStaleModel()now only falls back todefaultModelwhen the active provider has no model set at all, instead of force-resetting any custom entry.Motivation and Context
Setting a custom model via "Custom…" in the model picker didn't stick —
postSettings()(called right afterupdateSetting("model", model)in bothchangeProviderModel()andconnectProvider(), and again on nearly every settings-affecting action) ranhealStaleModel(), which force-reverted the model back todefaultModelwhenever it wasn't a member of the hardcodedmodels: string[]list. Reported against Ollama, but reproduces for every entry inPROVIDER_CATALOG.Closes #32.
Types of changes
Checklist