🪲 BUG-#8: Kill child process on extension deactivate - #17
Merged
Conversation
FernandoCelmer
commented
Aug 15, 2026
Member
Author
There was a problem hiding this comment.
🔍 Code Review
Code issues found: 1
| # | Severity | Comment |
|---|---|---|
| 1 | [Suggestion] | Use context.subscriptions instead of module-level variable |
…dispose the provider
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
src/extension.ts: Added module-levelactiveProviderreference, assigned inactivate(), and wired intodeactivate()to callChatViewProvider.dispose().src/vscode/sidebar/chatSidebarProvider.ts: Addeddispose()method that forwards toChatController.dispose()(already idempotent).Motivation and Context
deactivate()was a no-op. Thepycodeloop servechild process was only killed viawebviewView.onDidDispose(), which does not fire (or fires too late) when the webview is hidden at the moment the extension host tears down (window close, reload, extension disable), leaving the process orphaned.Closes #8
Types of changes
Checklist