✨ FEATURE: Include the diff preview in chat/autoApproved - #47
Merged
Conversation
Auto-approve skipped chat/confirmRequest entirely, so an auto-approved write_file/edit_file/delete_file call never carried its unified diff to the client — only chat/confirmRequest did. The diff was already computed via tool.preview() before this notification fires; just wasn't forwarded.
7 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion change for a vscodeloop UI improvement: the chat panel now
renders a file-edit's diff inline in its tool card even when
auto-approve is on.
confirm()already computestool.preview()before deciding whether to round-trip a
chat/confirmRequest— thisjust forwards that same string on the
chat/autoApprovedpathinstead of dropping it.
Test plan
chat/autoApproved's params include the write'sdiff preview
poetry run pytest -q— 282 passedpoetry run ruff check/ruff format --checkclean