⚠️ SECURITY-#24: Gate EnvTool behind confirmation - #34
Merged
Conversation
FernandoCelmer
commented
Aug 15, 2026
FernandoCelmer
left a comment
FernandoCelmer
left a comment
Member
Author
There was a problem hiding this comment.
Adding dangerous = True and a preview() to EnvTool is the right call — it brings env inspection behind the same confirmation gate as bash, write_file, and delete_file. Tests are precise. One inaccuracy in the preview message found below.
…closes preview() said "list every variable name" for the no-argument case, but run() without a name returns every NAME=value pair (values masked, not omitted) — misleading a user approving the confirmation prompt into thinking only names would be exposed.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Gates
EnvToolbehind user confirmation (issue #24). Addsdangerous = Trueand apreview()method that names the variable being read or warns that all variable names will be listed. This brings environment variable access into the same confirmation gate asbash,write_file, anddelete_file.Motivation and Context
Closes #24.
EnvToolhad nodangerousflag, allowing the agent to silently enumerate all environment variable names and probe individual values with no user-visible confirmation. The only existing guardrail was value masking, which does not prevent disclosure of secret variable names.Types of changes
Checklist