🪲 BUG-#18: Fix permanent provider fallback across run() calls - #32
Merged
Conversation
FernandoCelmer
commented
Aug 15, 2026
FernandoCelmer
left a comment
Member
Author
There was a problem hiding this comment.
The fix is correct and minimal. Resetting _provider_index and self.provider at the top of run() ensures each new user message gives the primary provider another chance, while fallback stickiness within a single run() (across _complete() turns) is preserved intentionally. The test covers the key invariants — primary is retried on a new run(), provider pointer is correct after recovery, and call counts are exact. No issues found.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes permanent provider fallback across
run()calls (issue #18)._provider_indexandself.providerare reset to the primary at the start of everyrun()call, so each new user message retries the primary provider first. Fallback stickiness is preserved within a singlerun()to avoid adding retry delays to every internal tool-call turn while the primary is down.Motivation and Context
Closes #18. Once the agent fell back to a secondary provider, it stayed on it for the entire process lifetime — even after the primary recovered. This caused unintended permanent use of fallback providers.
Types of changes
Checklist