DONT MERGE: Primeng 18 with Lara Theme #31321
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmontes
requested review from
a team,
oidacra,
nicobytes,
valentinogiardino,
zJaaal,
rjvelazco,
KevinDavilaDotCMS and
hmoreras
and removed request for
a team
|
Semgrep found 1 Risk: Affected versions of rollup are vulnerable to Improper Neutralization of Input During Web Page Generation ('Cross-site Scripting'). Manual Review Advice: A vulnerability from this advisory is reachable if you use Rollup to bundle JavaScript with Fix: Upgrade this library to at least version 4.22.4 at core/core-web/yarn.lock:20607. Reference(s): GHSA-gcx4-mw62-g8wm, CVE-2024-47068 |
zJaaal
requested changes
Feb 6, 2025
| @@ -19,7 +19,7 @@ export default [ | |||
| '/api/vtl', | |||
| '/tinymce' | |||
| ], | |||
| target: 'http://localhost:8080', | |||
fmontes
changed the title
|
Please use a Conventional Commit title format for this PR. For more information, see https://www.conventionalcommits.org/en/v1.0.0/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PrimeNG Components Modernization and UI Improvements
Summary
This PR includes a comprehensive update to modernize our PrimeNG implementation, improve component accessibility, and clean up legacy code. The changes focus on updating deprecated modules, enhancing UI consistency, and improving the overall developer experience.
Changes
p-tabsclasses across componentsInputTextareaModule→TextareaModuleDynamicDialogModule→DynamicDialogChipsModule→Chipin autocomplete tagsAdditional Notes
These changes are part of our ongoing effort to modernize our UI components and maintain consistency with PrimeNG's latest best practices. The updates should improve both the developer experience and end-user accessibility.