Hackathon (Core) - Telemetry and analytics #31318
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdotcms
reviewed
Feb 10, 2025
| import javax.servlet.http.HttpServletRequest; | ||
| import javax.servlet.http.HttpServletResponse; | ||
|
|
||
| public class ContentAnalyticsUtil { |
There was a problem hiding this comment.
Doc me and probably helper will be a more accurate name
jdotcms
reviewed
Feb 10, 2025
|
|
||
|
|
||
| //Logging analytics for FTM if the publishing date is older than five minutes now | ||
| if (timeMachineDateInstant.isPresent() && isOlderThanFiveMinutes(timeMachineDateInstant.get())) { |
There was a problem hiding this comment.
this looks such as the same code, so may want to encapsulate in a method
jdotcms
reviewed
Feb 10, 2025
| @@ -223,6 +226,10 @@ private MetricStatsCollector() { | |||
| metricStatsCollectors.add(new CountOfTimeFieldsMetricType()); | |||
| metricStatsCollectors.add(new CountOfWYSIWYGFieldsMetricType()); | |||
|
|
|||
| metricStatsCollectors.add(new TotalSitesUsingDotaiMetricType()); | |||
jdotcms
reviewed
Feb 10, 2025
| import java.util.Map; | ||
| import java.util.Optional; | ||
|
|
||
| public class TotalEmbeddingsIndexesMetricType implements MetricType { |
jdotcms
reviewed
Feb 10, 2025
| import java.util.Optional; | ||
| import java.util.Set; | ||
|
|
||
| public class TotalSitesUsingDotaiMetricType implements MetricType { |
jdotcms
reviewed
Feb 10, 2025
| return Optional.of(new MetricValue(this.getMetric(), sitesWithConfigurations.size())); | ||
| } catch (final DotSecurityException e) { | ||
| throw new DotDataException(e); | ||
| } |
There was a problem hiding this comment.
finally here to destroy the secrets
jdotcms
reviewed
Feb 11, 2025
| import java.util.Optional; | ||
| import java.util.Set; | ||
|
|
||
| public class TotalSitesWithAutoIndexContentConfigMetricType implements MetricType { |
jdotcms
reviewed
Feb 11, 2025
| return Optional.of(new MetricValue(this.getMetric(), counter)); | ||
| } catch (final DotSecurityException e) { | ||
| throw new DotDataException(e); | ||
| } |
jdotcms
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Focusing on adding new event types and sources, and enhancing the CLI tool with analytics tracking capabilities. The most important changes include adding new event sources and types, creating a new analytics API, and modifying the CLI tool to support event recording.
Event Source and Type Additions:
dotCMS/src/main/java/com/dotcms/analytics/track/collectors/EventSource.java: AddedDOT_CLIas a new event source.dotCMS/src/main/java/com/dotcms/analytics/track/collectors/EventType.java: AddedCMD_EXECUTEDas a new event type.Analytics API Implementation:
tools/dotcms-cli/api-data-model/src/main/java/com/dotcms/api/AnalyticsAPI.java: Created a newAnalyticsAPIinterface to handle custom user events.tools/dotcms-cli/api-data-model/src/main/java/com/dotcms/model/analytics/AbstractDotCliEvent.java: Defined a newAbstractDotCliEventinterface for CLI event data.CLI Tool Enhancements:
tools/dotcms-cli/cli/src/main/java/com/dotcms/cli/command/CustomConfigurationUtil.java: InjectedRestClientFactoryto support the new analytics API. [1] [2] [3] [4]tools/dotcms-cli/cli/src/main/java/com/dotcms/cli/common/DotExecutionStrategy.java: Modified the execution strategy to record events asynchronously using the new analytics API. [1] [2] [3] [4] [5]Additional changes: