fix: resolve mic_config.json path relative to project root#9
Open
mitchellecm7 wants to merge 1 commit into
Open
fix: resolve mic_config.json path relative to project root#9mitchellecm7 wants to merge 1 commit into
mitchellecm7 wants to merge 1 commit into
Conversation
|
👀 We've notified the reward creators here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
helpers/mic.pyhardcodedCONFIG_FILE = "config\\mic_config.json"— a path that doesn't exist in the repo and breaks on non-Windows systems.Fix: resolve the path relative to
mic.py's own location so it always points tomic_config.jsonat the project root, regardless of working directory or OS./claim #7