Fix microphone config path handling#8
Open
tinyopsstudio wants to merge 2 commits into
Open
Conversation
Add tests/test_mic_config.py
|
👀 We've notified the reward creators here. |
Author
|
Hi, quick follow-up on this PR. The patch remains focused on the microphone config path and includes the unittest, py_compile, and diff-check verification in the PR body. I am happy to adjust it if you prefer one of the competing approaches; if another PR is preferred, a close or decline signal would also help keep the Opire claim state accurate. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7
/claim #7
Summary:
mic_config.jsonby default instead ofconfig\mic_config.jsonBONZI_MIC_CONFIGto override the config path for tests or custom installspyaudioso config load/save can be tested without audio hardware bindingsunittestcoverage for missing config and save/load round tripWhy:
mic_config.jsonin the project root, buthelpers/mic.pylooked for a Windows-styleconfig\mic_config.jsonpath and emitted a Python invalid escape warningconfigdirectoryVerification:
python3 -m unittest discover -s testspython3 -m py_compile main.py helpers/*.py tests/*.pygit diff --checkNo private credentials, tokens, or local config values are included.