fix: prevent duplicate user message when clicking chatbot suggested prompt#148
Merged
fix: prevent duplicate user message when clicking chatbot suggested prompt#148
Conversation
…rompt (#146) When clicking a suggested prompt, a race condition between sendMessage (initialPrompt effect) and fetchSessionDetail (selectedSessionId effect) could cause the same user message to appear twice. Skip overwriting messages via setMessages after the initial prompt has been submitted.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #146
When clicking a suggested prompt on the Chatbot welcome page, the same user message appeared twice in the conversation. This was caused by a race condition between:
sendMessage(triggered by theinitialPrompteffect inchatbox.tsx) — adds the user message to local state and sends it to the APIfetchSessionDetail(triggered byselectedSessionIdchange insession-controller.ts) — fetches messages from server, which may already include the just-sent messageThe
setMessages(initialMessages)call fromfetchSessionDetailoverwrote the local message state with server data that included the user message, whileuseChatalso had the same message fromsendMessage, causing duplication.Fix: Skip
setMessages(initialMessages)after the initial prompt has been submitted, preventing the race condition from overwriting local state.Test plan
tsc --noEmit)