Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made changes equal to PR 716 #725

Merged
merged 6 commits into from
Feb 12, 2019
Merged

Made changes equal to PR 716 #725

merged 6 commits into from
Feb 12, 2019

Conversation

jlopez616
Copy link
Collaborator

@jlopez616 jlopez616 commented Feb 4, 2019

This PR addresses part of the following issue:
#698

Here I created a pipeline of data from graph.js to api.js to support a gene symbol, species name, and taxon id.

The changes are the same as those in PR #716 , but no changes were made to package.json or package-lock.json. Because of this, I was able to successfully export the graph to a file when I ran through the PR checklist.

@jlopez616
Copy link
Collaborator Author

jlopez616 commented Feb 4, 2019

Received the following error through the travis-ci build:

4.16s$ npm ci 
npm ERR! Unexpected end of JSON input
npm ERR! A complete log of this run can be found in:
npm ERR!     /home/travis/.npm/_logs/2019-02-04T20_25_38_014Z-debug.log
The command "eval npm ci  " failed. Retrying, 2 of 3.'

Tried running "npm update" to see if it would address the issue recieved the following terminal error:

npm ERR! Unexpected end of JSON input while parsing near '...1.0.0",
npm ERR!             
npm ERR! '

The same error occurred when I tried "npm install".

I believe this is directly related to #717 . Will move forward with this when updates are made there.

@jlopez616
Copy link
Collaborator Author

jlopez616 commented Feb 11, 2019

Moving checklist down here:

Pull Request Checklist

  • Travis C.I. build passes
  • All four Demos look as expected when loaded
  • Reload works as expected
  • Loading file with Error brings up error modal, and it looks as expected
  • Loading file with Warning brings up warnings modal
  • Import works for both SIF and GraphML
  • Graph can be exported to SIF and GraphML
  • Print works as expected
  • Restrict graph to viewport works as expected (check/uncheck)
  • Viewport Size Changing works as expected (small/medium/large/fit)
  • Toggle between Grid Layout and Force Graph Layout works as expected
  • Force Graph Parameter Sliders change the number above them and have an effect on the graph
  • Locking/Unlocking/Resetting/Undo Resetting the force graph parameters works as expected
  • Enabling and disabling node coloring works as expected
  • Node coloring options work as expected (selection top/bottom dataset, averaging values, changing max value)
  • Weighted graph loaded with the "default to black edges" option checked appears as expected
  • Hide/Show Weights works as expected (always/never/upon mouseover)
  • Edge Weight Normalization Factor can be changed (set/reset)
  • Gray Edge Threshold can be changed, slider changes the number and has an effect on the graph
  • Checking Show Gray Edges as Dashed works as expected (check/uncheck)
  • D-pad left/right/top/bottom/center works as expected
  • Zoom slider changes number and has effect on graph (viewport and menu)
  • Right click on a node opens gene page, page is populated with correct data

@jlopez616
Copy link
Collaborator Author

Closed PR #716 in lieu of the changes made on this branch.

@jlopez616
Copy link
Collaborator Author

@mihirsamdarshi or @afiller1 May one of you pull this branch and run it on your machine? For some reason, I'm unable to make changes to graph.js and have them be applied to npm run start-dev. I'll bring this up at today's meeting as well.

Copy link
Owner

@dondi dondi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dondi dondi merged commit e219d69 into beta Feb 12, 2019
@dondi dondi deleted the johnlopez_old_issues branch February 12, 2019 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants