#1082: Fixed Fit to Window Functionality #1168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng host_site to https://localhost:8080
… since empty dimensions are being sent and propogated throughout code before they are received, and will add a Promise to ensure that wait for dimensions to be sent before running the rest of the code for displaying graph.
…sole that width of grnstate.dimensions is undefined when run fitContainer
…p is called again after the grnState.dimensions are set. while grnState.dimensions are undefined, leave the container as the current size in fitContainer, and finally update the size in fitContainer when grnState.dimensions is not undefined
…lhost domains 5001 and 8080
dondi
reviewed
Jan 29, 2025
| @@ -40,7 +40,7 @@ const sendDimensions = (destination, origin) => { | |||
| }; | |||
|
|
|||
| window.addEventListener("message", event => { | |||
| if (event.origin.indexOf("https://grnsight.lmucs.org") !== 0) { | |||
| if (event.origin != "https://grnsight.lmucs.org") { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved Issue #1082 by adjusting logic in
fitContainerfunction so that graph is updated with correct dimensions of window and adjusted communication between iframe and GRNsight.