Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bounding box for graph should have fixed length and width and not change with resizing of window #146

Closed
kdahlquist opened this issue Oct 6, 2014 · 9 comments

Comments

@kdahlquist
Copy link
Collaborator

I noticed something that might be related to our ability to print a full graph (#111).

When resizing the browser window in Firefox, I noticed that the width of the bounding box changes as I change the size of the window. This doesn't happen when I resize in the vertical direction.

The bounding box should be of a fixed dimension. Resizing the browser window smaller than that should activate the scroll bars, not adjust the size of the actual bounding box.

Zooming in or out should not change the size of the bounding box either--it should have one fixed size that we can change the view of, but not actually change the size of the box.

This might be related to the printing issue because the graph is getting cut off in Firefox, so it might be thinking that the bounding box is in a different place because of the way the box is interacting with the browser window.

@kdahlquist
Copy link
Collaborator Author

If the minimum width is still active at print, could be causing the print problem (#111).

We will think about the design decision of how we want this to behave.

@NAnguiano
Copy link
Collaborator

I set the bounding box to be a fixed size. Let me know what you think of the size. The iFrame scrolls when the screen or web browser is below the width.

@kdahlquist
Copy link
Collaborator Author

change the dimensions of the containing iframe so that it is big enough to accommodate the content embedded. iframe.embedded-demo = 1350

@kdahlquist
Copy link
Collaborator Author

I don't know if yesterday's change got pushed to beta or not. I just looked at it now on my laptop (not the larger monitor) and the bounding box scroll bars (both vertical and horizontal) were activated when I first loaded the page. There is about 3 inches of white space to the right of the bounding box.

@NAnguiano
Copy link
Collaborator

I forgot to push it to the server. The changes are live now.

@kdahlquist
Copy link
Collaborator Author

I just looked again--this time from my large monitor and the vertical and horizontal scroll bars around the bounding box are still there.

@NAnguiano
Copy link
Collaborator

Hm.. how strange. Neither show up on my machine. I pushed a change that hopefully fixes it, so let me know if it got rid of it for you now.

@kdahlquist
Copy link
Collaborator Author

The scroll bars are gone. I'd like to do a little "live" editing of this during the meeting to see how large we can get the bounding box without getting strange behavior.

@kdahlquist
Copy link
Collaborator Author

For a small laptop, the current settings work well so we will leave it like it is. For the future, we can explore having an options for a small, medium, and large bounding box to accommodate larger screens. Started new issue #159 for this. Will close this one for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants