-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable print function in our menu #111
Comments
Main way that this is done is to use CSS media rules (e.g., there are ways to say how something should look when displayed onscreen vs. when printed). Most frequent use is to hide/show certain elements depending on print or screen media. |
Initial exploration is OK, but now we can just do print CSS for the entire website. Remove sidebar and header for all web pages when printed. |
Also need to look into why blank pages are appearing at the end. Experiment: change the background color to something other than white. |
Just tested beta on firefox:
|
I've committed a fix to |
It seems to work fine in Chrome, but I'm still seeing 2 pages in Firefox when I view the printed page as a PDF in preview on my mac. |
How does it look for you standalone? Do you get 2 pages then, or 1? It may be that more work needs to be done when the graph is framed as with github.io. |
In localhost, it's 1 page in Chrome and 2 pages in firefox. |
OK, that is helpful...Firefox localhost was also 1 page for me, oddly enough. Looks like more digging is called for then. |
Some updates:
|
Another possibility: when printing, assign dimensions in inches. That should make it easier to map sizes onto paper. |
So here is my report:
So with the laptop unplugged from the docking station/monitor, l tried printing again.
|
I tested it on three different computers and here are the results. I didn't get a chance to test any of these in Landscape mode, so all of these are in Portrait mode. Once I get access to the last two computers again, I'll check how they prnt in Landscape mode. The first computer was a laptop running Windows 7, 15" screen and 1920x1080 resolution. The second computer was a PC running Windows 7, 27" screen and 2560 x 1440 resolution. The last computer was a laptop running Windows 7, 15" screen and 1366x768 resolution. |
Approach:
|
If the minimum width is still active at print, could be causing the print problem (#146). |
Checked the code and can confirm that there is a |
We two workarounds that we need to add to the documentation page:
After the change is made to the documentation, let's just close this issue. |
OK--here is some language to put in the Documentation page: Replace the last bullet point of section three with: To print a graph, select the menu item File > Print. Mac users can utilize native print to PDF function available from their operating system to print the graph to a PDF file. Windows users will need to have the full version of Adobe Acrobat (or other "print to PDF" utility) to print graphs to a PDF file. The Print menu item is disabled until a gene regulatory network graph is loaded. There is a known bug when GRNsight is used with Firefox browsers where the side of the graph gets cut off. This is an issue with Firefox that we cannot solve at this time. There are two workarounds. First, in Firefox, go to the menu item File > Page Setup and check the box Shrink to fit Page Width. Second, you can ues the Chrome browser to print to PDF. |
I went ahead and replaced the last bullet point with that text. Reassigning for review. |
I just noticed that one of the sentences has an awkward phrase in it (my fault for not catching this sooner). Replace the first two sentences of that bullet point with: To print a graph, select the menu item File > Print. Mac users can utilize the native print to PDF function available from their operating system to print the graph to a PDF file. |
Just switched out those two sentences with the revised version above. Reassigning for review. |
Confirmed change and am closing. |
Instead of dealing with fancy export function, we will enable print function in our menu so that if the user has a print to pdf on their computer they can do it. #59
The text was updated successfully, but these errors were encountered: