ControllerEmu: Remove nunchuk stick data hax. #13177
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hack was introduced 11 years ago in 9b20280
They claimed some "programs" don't properly detect movement if the Nunchuk stick is pushed perfectly vertically or horizontally.
The old commit message said "it's expected by some emulated programs".
Which "programs"?
I find it somewhat hard to believe any legitimate game behaves in this manner.
It would be apparent on real hardware.
If it turns out these games actually exist, we can add the hack back with a proper comment mentioning the actual problem-game.