Add test for empty response with 204 status

dolamroth · Sep 17, 2023 · 2ad9e3e · 2ad9e3e
1 parent 17e11c8
commit 2ad9e3e
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 2 deletions.
diff --git a/starlette_web/common/http/base_endpoint.py b/starlette_web/common/http/base_endpoint.py
@@ -91,7 +91,7 @@ async def dispatch(self) -> None:
             if settings.REMOVE_BODY_FROM_RESPONSE_WITH_NO_BODY:
                 response.body = b""
             elif response.body:
-                response.headers.append("content-length", str(len(response.body)))
+                response.headers.update({"content-length": str(len(response.body))})
 
         await response(self.scope, self.receive, self.send)
 

diff --git a/starlette_web/tests/core/test_responses.py b/starlette_web/tests/core/test_responses.py
@@ -0,0 +1,5 @@
+def test_empty_response(client):
+    # This test covers ability of starlette-web to circumvent design of uvicorn library,
+    # which forbids sending any request body for 204, 304 responses
+    response = client.get("/empty/")
+    assert response.content == b"null"
diff --git a/starlette_web/tests/routes.py b/starlette_web/tests/routes.py
@@ -13,6 +13,7 @@
     FinitePeriodicTaskWebsocketTestEndpoint,
     InfinitePeriodicTaskWebsocketTestEndpoint,
     ChatWebsocketTestEndpoint,
+    EmptyResponseAPIView,
 )
 
 
@@ -24,6 +25,7 @@
     Mount("/static", app=StaticFiles(directory=settings.STATIC["ROOT_DIR"]), name="static"),
     Mount("/media", app=StaticFiles(directory=settings.MEDIA["ROOT_DIR"]), name="media"),
     Route("/health_check/", HealthCheckAPIView),
+    Route("/empty/", EmptyResponseAPIView, include_in_schema=False),
     WebSocketRoute("/ws/test_websocket_base", BaseWebsocketTestEndpoint),
     WebSocketRoute("/ws/test_websocket_cancel", CancellationWebsocketTestEndpoint),
     WebSocketRoute("/ws/test_websocket_auth", AuthenticationWebsocketTestEndpoint),

diff --git a/starlette_web/tests/views/__init__.py b/starlette_web/tests/views/__init__.py
@@ -1,6 +1,6 @@
 # flake8: noqa
 
-from starlette_web.tests.views.http import HealthCheckAPIView
+from starlette_web.tests.views.http import HealthCheckAPIView, EmptyResponseAPIView
 from starlette_web.tests.views.websocket import (
     BaseWebsocketTestEndpoint,
     CancellationWebsocketTestEndpoint,

diff --git a/starlette_web/tests/views/http.py b/starlette_web/tests/views/http.py
@@ -67,3 +67,10 @@ async def get(self, *_):
             data=response_data,
             status_code=result_status,
         )
+
+
+class EmptyResponseAPIView(BaseHTTPEndpoint):
+    auth_backend = None
+
+    async def get(self, *_):
+        return self._response(status_code=204)