fix(katana): move rpc merge outside of cfg feature server

[notV4l]

Summary by CodeRabbit

• New Features
  • Updated configuration behavior so that RPC settings are now consistently applied in all contexts. This change ensures uniform application of these settings, providing a more predictable and reliable user experience with respect to RPC-related functionalities.

[coderabbitai]

Ohayo, sensei! Below is the detailed analysis for this pull request.

Walkthrough

The pull request updates the with_config_file method in the NodeArgs implementation by removing the conditional merge of the rpc configuration based on the server feature. The RPC settings are now merged unconditionally after the starknet and development configurations, affecting the control flow of how configurations are applied. There are no changes to exported or public entities.

Changes

File(s)	Summary
crates/katana/cli/src/args.rs	Updated the with_config_file method: Removed the conditional merge for rpc under the server feature and added an unconditional merge for rpc after other configs.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant NodeArgs
    participant Config

    User->>NodeArgs: Call with_config_file(config)
    NodeArgs->>Config: Merge starknet config
    NodeArgs->>Config: Merge development config
    NodeArgs->>Config: Merge rpc config (always)

Loading

Possibly related PRs

• fix: katana granular config for starknet #2677: Also updates the with_config_file method in the NodeArgs implementation, directly relating to configuration merging.
• fix(katana): merging server args from file #3044: Alters the handling of the server field in the with_config_file method and introduces a new merge method in the ServerOptions struct, closely connected to how server configurations are managed.

Suggested reviewers

• kariy
• glihm

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)

• We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
  - To enable this feature, set early_access to true under in the settings.

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e561673 and 4018875.

📒 Files selected for processing (1)

• crates/katana/cli/src/args.rs (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: fmt

🔇 Additional comments (1)

crates/katana/cli/src/args.rs (1)

441-441: LGTM: Good change to handle RPC configuration unconditionally

Ohayo sensei! This is a clean change that improves the code by moving the RPC merge outside of the conditional server feature block. Now RPC settings from the config file will always be merged, regardless of whether the server feature is enabled, making the behavior more consistent with how other configurations are handled.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.21%. Comparing base (e561673) to head (4018875).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3103      +/-   ##
==========================================
- Coverage   57.21%   57.21%   -0.01%     
==========================================
  Files         446      446              
  Lines       60618    60618              
==========================================
- Hits        34685    34683       -2     
- Misses      25933    25935       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.