Make grunt working again. #221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reference to the issue mentioned above: #220. |
jgonggrijp
reviewed
Jul 9, 2020
There was a problem hiding this comment.
@mafiosso Do I understand correctly that grunt test works fine if you first run grunt dist?
In what way do the newly generated uglified+minified files differ from the committed uglified+minified files?
Co-authored-by: Julian Gonggrijp <[email protected]>
jgonggrijp
approved these changes
Jul 9, 2020
|
@mafiosso Please reopen. I meant that the contents of |
|
The changes look fine. However, I found that when running npm test, puppeteer would hang even on the unminified and unconcatenated source. Are either of you seeing this issue? |
|
Looks like that was a temporary fluke on my machine. These changes look good. Thanks! |
|
Thanks for checking and for merging, @joshuacc! |
jgonggrijp
added a commit
to jgonggrijp/underscore-contrib
that referenced
this pull request
Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves first step of mentioned maintenance -1. Fix things so that development is smooth again. Upgraded grunt and its dev-dependencies. Note that tests are executed via puppeteer now which uses Chromium. Puppeteer freezes on old minified/uglyfied files, but works well on firefox manully. When running
npm disteverything works smooth then. I am not sure if commit products ofnpm distfor now - possible lost of backward compatibility for user of latest version.