-
Notifications
You must be signed in to change notification settings - Fork 2.5k
fix: non-managed properties should trigger proxy load #11606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
bcbeaad
fix: non managed properties should trigger proxy load
priyadi 273b07a
cs
priyadi 9d5106c
use static variable for testing to avoid triggering proxy load
priyadi bba8f93
reset $staticPostLoadCallbackInvoked on setUp
priyadi a71539f
remove typed properties
priyadi e9fb6a1
remove type hint
priyadi 8aec2d6
change will(returnValue) to willReturn
priyadi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace Doctrine\Tests\Models\Product; | ||
|
|
||
| use Doctrine\ORM\Mapping as ORM; | ||
|
|
||
| /** | ||
| * @ORM\Entity | ||
| */ | ||
| #[ORM\Entity] | ||
| class Product | ||
| { | ||
| /** | ||
| * @var int | ||
| * @ORM\Id | ||
| * @ORM\Column() | ||
| * @ORM\GeneratedValue | ||
| */ | ||
| #[ORM\Id] | ||
| #[ORM\Column()] | ||
| #[ORM\GeneratedValue] | ||
| private $id = 42; | ||
|
|
||
| /** | ||
| * @var string | ||
| * @ORM\Column() | ||
| */ | ||
| #[ORM\Column()] | ||
| private $name; | ||
|
|
||
| /** | ||
| * @var string|null | ||
| */ | ||
| private $image = null; | ||
|
|
||
| public function __construct(string $name) | ||
| { | ||
| $this->name = $name; | ||
| } | ||
|
|
||
| public function getId(): int | ||
| { | ||
| return $this->id; | ||
| } | ||
|
|
||
| public function getName(): string | ||
| { | ||
| return $this->name; | ||
| } | ||
|
|
||
| public function getImage(): ?string | ||
| { | ||
| return $this->image; | ||
| } | ||
|
|
||
| public function setImage(string $image): void | ||
| { | ||
| $this->image = $image; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.