Skip to content

Conversation

@stof
Copy link
Member

@stof stof commented Jul 5, 2024

PostLoad listeners might initialize values for transient properties, so the proxy should not skip initialization when using transient properties.

Closes #11524

PostLoad listeners might initialize values for transient properties, so
the proxy should not skip initialization when using transient
properties.
@stof stof added the Bug label Jul 5, 2024
@stof
Copy link
Member Author

stof commented Jul 30, 2024

the failing tests are because the testsuite currently relies on unmapped public properties to track the usage of postLoad listeners.
For doctrine/common proxies, public properties were unsupported and were not triggering initialization (public methods were the trigger, and using a public property was allowing to skip using any method), which was a known limitation of the proxy system (meant to be solved by the new system, among other things)
For the initial implementation of the lazy-ghost proxies, mapped properties were the trigger, making those tests work as well (as those are unmapped properties). But as this PR is precisely about changing the trigger to be all properties, tests will need a different way to track usage.

@nicolas-grekas
Copy link
Member

Would it make sense to do this only when there are postload listeners?
Alternatively, it means we should "skip" the properties used in tests, right?

@stof
Copy link
Member Author

stof commented Sep 24, 2024

I wanted to refactor those tests to store the initialization tracking externally, but I haven't done it yet (I kinda forgot this PR)

@nicolas-grekas
Copy link
Member

/cc @priyadi

@github-actions
Copy link
Contributor

There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days.
If you want to continue working on it, please leave a comment.

@github-actions github-actions bot added the Stale label Dec 24, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2025

This pull request was closed due to inactivity.

@github-actions github-actions bot closed this Jan 7, 2025
@dannyvw
Copy link

dannyvw commented Mar 11, 2025

Is there perhaps an update for this issue?

@stof
Copy link
Member Author

stof commented Mar 11, 2025

I haven't had the time to go back at it to update the tests. But I saw that #11853 had similar needs to update the tests, so I might be able to borrow from it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants