Convert configs from xml to php

[alexander-schranz]

• just did run the converter: https://github.com/GromNaN/symfony-config-xml-to-php
• fixed include profiler routes

Targets: #410

[alexander-schranz]

@dbu maybe you want already merge this into the sf8 branch. Still doctrine/phpcr-odm#881 would be require to forward with the upgrade.

[dbu]

thanks!
regarding the phpstan failures: do you know the policy/best practices for optional dependencies? should we not define services when the class does not exist? and i guess it would make sense to add all optional dependencies for the phpstan check, to ensure there are no typos there.

[alexander-schranz]

@dbu Optional Dependencies should be added as require-dev so static code analyzing still works via PHPStan.

Keep in mind there are some errors which existed previously service id is:

\Doctrine\Bundle\PHPCRBundle\OptionalCommand\InitDoctrineDbalCommand::class, 

But class is:

\Doctrine\Bundle\PHPCRBundle\OptionalCommand\Jackalope\InitDoctrineDbalCommand::class

---

Should we not define services when the class does not exist?

I would say no. Atleast that is how I handle it, wouldn't lint:container fails else?

---

If you want get best out of Static code analyzing you would require have multiple phpstan configs and baselines depending on installed dependency and handle in the CI have some dependency installed and run PHPStan against it and other runs without specific deps installed. Never did that yet as I think hard maintainance work.

[alexander-schranz]

Is prismic even still a thing? The repo https://github.com/jackalope/jackalope-prismic was never updated and not even sure if they still on JCR?

[dbu]

namespace of InitDoctrineDbalCommand

oh wow 🤦 i guess we should add an alias for the correct one then.

prismic looks quite dead indeed. oh, and yay we can simply drop it - it only works with jackalope 1, and this bundle declares a conflict with jakalope < 2, so there is no risk of breaking anybody's stuff.

shall i handle it or do you want to work on it?

[alexander-schranz]

Fine if you handle it :)