Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some CS rules #2507

Merged
merged 1 commit into from
Sep 2, 2022
Merged

Fix some CS rules #2507

merged 1 commit into from
Sep 2, 2022

Conversation

phansys
Copy link
Collaborator

@phansys phansys commented Aug 21, 2022 •
edited
Loading

@phansys phansys requested a review from franmomu August 21, 2022 22:45
@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2022 •
edited
Loading

Codecov Report

Merging #2507 (a502241) into main (70e9681) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2507   +/-   ##
=========================================
  Coverage     80.07%   80.07%           
  Complexity     3145     3145           
=========================================
  Files           158      158           
  Lines          7705     7705           
=========================================
  Hits           6170     6170           
  Misses         1535     1535

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@phansys phansys changed the title Add "phpdoc_no_empty_return" CS rule Fix some violations to "@DoctrineAnnotation" CS ruleset Aug 21, 2022
@phansys phansys changed the title Fix some violations to "@DoctrineAnnotation" CS ruleset Fix some CS rules Aug 21, 2022
@phansys phansys marked this pull request as ready for review August 21, 2022 23:39
@phansys
Fix some violations to "@DoctrineAnnotation" CS ruleset + Disallow "f…
0b15c24 
…riendsofphp/php-cs-fixer" >= 3.10 in order to avoid inconsistencies with "phpdoc_order" rule
@phansys phansys merged commit 49f2808 into doctrine-extensions:main Sep 2, 2022
@phansys phansys deleted the cs branch September 2, 2022 18:39
@phansys phansys mentioned this pull request Sep 7, 2022
Merged
@phansys phansys mentioned this pull request Jun 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franmomu franmomu Awaiting requested review from franmomu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phansys @codecov-commenter