Open
Conversation
kaleidoscopikatt
changed the title
ekulxam
suggested changes
Nov 29, 2025
src/main/java/dev/doctor4t/trainmurdermystery/compat/controlify/ControlifyEntrypoint.java
Outdated
Show resolved
Hide resolved
.../java/dev/doctor4t/trainmurdermystery/compat/controlify/LimitedInventoryScreenProcessor.java
Outdated
Show resolved
Hide resolved
...ain/java/dev/doctor4t/trainmurdermystery/mixin/client/restrictions/MinecraftClientMixin.java
Outdated
Show resolved
Hide resolved
...ain/java/dev/doctor4t/trainmurdermystery/mixin/client/restrictions/MinecraftClientMixin.java
Outdated
Show resolved
Hide resolved
...ain/java/dev/doctor4t/trainmurdermystery/mixin/client/restrictions/MinecraftClientMixin.java
Show resolved
Hide resolved
ekulxam
suggested changes
Nov 30, 2025
| return; | ||
| } | ||
| @Shadow | ||
| public void setScreen(Screen screen) {} |
Contributor
Author
There was a problem hiding this comment.
Why would we need this? I know it used to be needed for older versions of Mixin but I don't know why we need it now
Contributor
There was a problem hiding this comment.
The shadowed method should be abstract to avoid the need to add a method body.
Contributor
|
See #95 (comment) |
Owner
|
What's the status on this PR, has it been tested? |
Contributor
Author
|
It has been tested, and it works fine on my machine. It has merge conflicts since recent commits, however. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #50