Conversation
Contributor
Author
|
Also fixed potential crash that could have occurred when attempting to read an invalid UUID. |
Contributor
Author
|
Unfortunately, that doesn't actually fix the issue, as a new PacketCodec is derived from the codec, so I'll need to fix that later. |
Contributor
Author
|
I've decided that this PR is not going to fix that issue because my WIP solution is likely to break a lot of things. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally from #22
Extracts duplicate logic in
PlayerEntityMixinandPoisonUtiltoPoisonUtil.updatePoisonTicks.Obtains UUID of poisoner earlier in
bedPoison. Previously, the UUID was set to null before being obtained, resulting in the UUID always being null.Add NotNull and Nullable annotations when acceptable.