-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update local and Vercel preview. Fix CSS watch functionality. #2348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This reverts commit c13422a.
3d8179a
to
acd69cd
Compare
Koooooo-7
reviewed
Dec 22, 2023
Koooooo-7
approved these changes
Dec 22, 2023
sy-records
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues the cleanup work done in #2316 by removing the need for additional files to be generated or copied to render either a preview or production docs site. The
/docs/
directory is a ready-to-be-served production site, and the local and Vercel server configurations are used to virtualize the necessary changes based on the files in/docs/
.FWIW, I would have done this in #2316, but I was unaware of Vercel's middleware capabilities.
If this PR is accepted, PRs #2317 and #2322 can be closed.
Summary
/preview
directory instead of/preview.html
file./docs/index.html
with URL rewrites/docs/
directory without modificationbuild:html
script and resultingpreview.html
fileRelated issue, if any:
#2218
close #2317
close #2322
What kind of change does this PR introduce?
Bugfix
Build-related changes
For any code change,
Does this PR introduce a breaking change?
No
Tested in the following browsers: