Skip to content

feat(vlm): Vlm dynamic prompt #1808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

shkarupa-alex
Copy link
Contributor

Some models (like OlmOcr) use raw text content to improve OCR quality. This requires dynamic prompt building with access to backend (implemented in this PR).

Checklist:

  • Documentation has been updated, if necessary.
  • Examples have been added, if necessary.
  • Tests have been added, if necessary.

Copy link
Contributor

github-actions bot commented Jun 18, 2025

DCO Check Passed

Thanks @shkarupa-alex, all your commits are properly signed off. 🎉

Copy link

mergify bot commented Jun 18, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

I, Shkarupa Alex <[email protected]>, hereby add my Signed-off-by to this commit: 34d446c
I, Shkarupa Alex <[email protected]>, hereby add my Signed-off-by to this commit: 9c595d5

Signed-off-by: Shkarupa Alex <[email protected]>
Copy link

codecov bot commented Jun 18, 2025

Codecov Report

Attention: Patch coverage is 31.25000% with 11 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../models/vlm_models_inline/hf_transformers_model.py 16.66% 5 Missing ⚠️
docling/models/api_vlm_model.py 0.00% 3 Missing ⚠️
docling/models/vlm_models_inline/mlx_model.py 0.00% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

@shkarupa-alex
Copy link
Contributor Author

Can somebody review this PR please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants