Skip to content

Commit

Permalink
Merge pull request #270 from docknetwork/feat/improve-ack-flow
Browse files Browse the repository at this point in the history
performance improvements for ack
  • Loading branch information
maycon-mello authored Jun 13, 2024
2 parents 16ac8be + cf1fdc7 commit f8a1723
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 13 deletions.
25 changes: 13 additions & 12 deletions packages/core/src/message-provider.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { logger } from '@docknetwork/wallet-sdk-data-store/src/logger';
import {logger} from '@docknetwork/wallet-sdk-data-store/src/logger';
import {IDIDProvider} from './did-provider';
import {WalletDocumentTypes, captureException} from './helpers';
import {IWallet} from './types';
Expand Down Expand Up @@ -135,20 +135,21 @@ export function createMessageProvider({
captureException(err);
}
}

for (const [did, messageIds] of Object.entries(messageIdsPerDid)) {
logger.debug(`Acknowledging messages for ${did}`);
let startTime = new Date().getTime();
// FIXME: https://dock-team.atlassian.net/browse/DCKM-415
// We don't need to wait for the ack to complete
// Those messages were already stored in the wallet
// I will let this as is for now until we see the full performance report
await relayService.ackMessages({
did,
messageIds,
});

logger.performance('Acknowledged messages', startTime);
relayService
.ackMessages({
did,
messageIds,
})
.then(() => {
logger.performance('Acknowledged messages', startTime);
})
.catch(err => {
console.error('Failed to ack messages', err.message);
});
}

if (encryptedMessages.length > 0) {
Expand Down
3 changes: 2 additions & 1 deletion packages/wasm/src/services/relay-service/service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,11 @@ export class RelayService {
name: string;

rpcMethods = [
RelayService.prototype.ackMessages,
RelayService.prototype.getMessages,
RelayService.prototype.sendMessage,
RelayService.prototype.registerDIDPushNotification,
RelayService.prototype.resolveDidcommMessage,
RelayService.prototype.sendMessage,
RelayService.prototype.signJwt,
];

Expand Down

0 comments on commit f8a1723

Please sign in to comment.