Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update install.sh (add TencentCloud download url) #408

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

89ao
Copy link

@89ao 89ao commented Apr 22, 2024

add TencentCloud download url

- What I did
add TencentCloud download url

- How I did it
add TencentCloud download url(https://mirrors.cloud.tencent.com) in the install.sh

- How to verify it
curl -fsSL https://get.docker.com -o get-docker.sh
sudo sh get-docker.sh --mirror TencentCloud

- Description for the changelog

Add the download address of TencentCloud to facilitate faster use by users within certain networks.

- A picture of a cute animal (not mandatory but encouraged)

add TencentCloud download url
correct domain name
@89ao
Copy link
Author

89ao commented Apr 24, 2024

Excuse me ,please help me check this request,thank you guys !@nicksieger @jgdavey @SvenDowideit @shykes

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing; I don't think we want to add more options to this list; the original list of mirrors were part of some partnerships (but those ended, so we may even consider removing those).

If you need to use a custom / alternative mirror, I would recommend using the DOWNLOAD_URL env-var when executing the script.

@VAllens
Copy link

VAllens commented Jul 24, 2024

Thanks for contributing; I don't think we want to add more options to this list; the original list of mirrors were part of some partnerships (but those ended, so we may even consider removing those).

If you need to use a custom / alternative mirror, I would recommend using the env-var when executing the script.DOWNLOAD_URL

I was planning to add TencentCloud as a mirror option and pull request.
So I found this place, and after seeing your comment, I realized that I've been using get-docker.sh for so long and never knew about the DOWNLOAD_URL environment variable.
This is great idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants