add cool webpage for get.docker.com

[duhruh]

[GordonTheTurtle]

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "feature/web-page" [email protected]:duhruh/docker-install.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

[seemethere]

Have a bit of an issue the way you defined the make targets, but everything looks good to me.

No idea why you're getting all the shellcheck issues though.

Seems as though adding the html makes shellcheck unhappy.

[seemethere]

This should actually just be build/docker.sh

And then the rule could be defined as:

.PHONY: build
build: build/docker.sh

build/docker.sh: install.sh index.html
	mkdir -p build
	@HTML='$(shell cat index.html)' envsubst < $< >> $@

Seems a bit convoluted to do it the way you're doing it here.

[nemchik]

A recent change to shellcheck seems to have made SC2034 a little more strict.

https://github.com/koalaman/shellcheck/releases/tag/v0.6.0 released Dec 3, 2018 but the latest tag on https://hub.docker.com/r/koalaman/shellcheck/tags was pushed Jul 4, 2019.

[seemethere]

I also believe the ensubst might be the issue, you need to be selective on which vars are going to be substituted, for reference: https://unix.stackexchange.com/a/294400/249966

[seemethere]

@duhruh can you rebase now that #131 is merged in, should hopefully make getting this in a bit easier.

[seemethere]

you should probably change this to a different href

[seemethere]

this is for shellcheck purposes

[MichaIng]

Hmm, actually I like to have the code shown in browser. Easiest way to quickly search through code from desktop. One can copy&paste or "save to file" as well. Not sure about the benefit of having a website instead which just shows the same command line that you very likely got the URL itself from? 😉