[28.x backport] opts, image/build: deprecate IsArchive, ValidateMACAddress, ListOpts.Delete() #6560
+67
−64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix minor linting issues (unhandled errors) - rename vars to prevent shadowing - use sub-tests for tests that already prepared for it Signed-off-by: Sebastiaan van Stijn <[email protected]> (cherry picked from commit 2c539a6) Signed-off-by: Sebastiaan van Stijn <[email protected]>
It was only used internally. Signed-off-by: Sebastiaan van Stijn <[email protected]> (cherry picked from commit 64be664) Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]> (cherry picked from commit 9e646f6) Signed-off-by: Sebastiaan van Stijn <[email protected]>
It was a wrapper around net.ParseMAC from stdlib, so users should use that directly. Signed-off-by: Sebastiaan van Stijn <[email protected]> (cherry picked from commit 17d6a92) Signed-off-by: Sebastiaan van Stijn <[email protected]>
This method was added as part of a refactor in [moby@1ba1138], at which time it was used to delete original values for "--host" and "--volume" after normalizing. This beccame redundant in [moby@6200002], which added specialized options that used a validate function, which both validated and normalized inputs. It's no longer used, so let's mark it deprecated so that we can remove it. [moby@1ba1138]: moby/moby@1ba1138 [moby@6200002]: moby/moby@6200002 Signed-off-by: Sebastiaan van Stijn <[email protected]> (cherry picked from commit 193db8e) Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
impact/deprecation
status/2-code-review
kind/refactor
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport:
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)