Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 4.1.0-beta.1 pre-release #738

Merged
merged 1 commit into from
Nov 16, 2024
Merged

Conversation

yosifkit
Copy link
Member

@yosifkit yosifkit commented Nov 14, 2024

🎉 A new RabbitMQ release series, 4.1. Still using Ubuntu 24.04, Alpine 3.20, and OpenSSL 3.3. Bump erlang to 27 for 4.1.x (#734). Updates the download URL to drop -latest-toolchain for 4.1+ (rabbitmq-server-generic-unix-{version}.tar.xz).

Closes #737
Closes #734

@michaelklishin
Copy link
Collaborator

michaelklishin commented Nov 14, 2024

@yosifkit would it be possible to change the directory suffix to 4.1-preview or something like that? We are a few months away from an RC.

If not, that's fine with me, I understand the value of naming conventions :)

@tianon
Copy link
Member

tianon commented Nov 15, 2024

Yeah, we've used rc as a naming convention for "pre-releases" across DOI for a long time, but we certainly don't have to! It's easier for us if we keep the folder named that way, but it shouldn't be too hard to make sure the actual image tags don't use rc in them yet 🤔

Right now, this will have tags 4.1.0-beta.1 and 4.1-rc (and variants like 4.1.0-beta.1-management, etc) -- would you want us to change that to 4.1-preview, or would you rather we drop that generic tag instead and only have the full explicit version? (the latter is easier, but the former isn't too bad if you prefer it)

@tianon
Copy link
Member

tianon commented Nov 15, 2024

Here's the easy version (drop the RC references from tags of a version that isn't an RC):

diff --git a/generate-stackbrew-library.sh b/generate-stackbrew-library.sh
index c97a15f..bf6885d 100755
--- a/generate-stackbrew-library.sh
+++ b/generate-stackbrew-library.sh
@@ -106,11 +106,15 @@ for version; do
 			versionAliases+=( $fullVersion )
 			fullVersion="${fullVersion%[.-]*}"
 		done
+		versionAliases+=( $version )
 	else
 		versionAliases+=( $fullVersion )
+		if [[ "$fullVersion" == *rc* ]]; then
+			# only add "X.Y-rc" alias if it's actually an RC
+			versionAliases+=( $version )
+		fi
 	fi
 	versionAliases+=(
-		$version
 		${aliases[$version]:-}
 	)
 

@michaelklishin
Copy link
Collaborator

@tianon no, let's keep things the way they are then. Thank you for the explanation!

@tianon tianon merged commit 5aeb28e into docker-library:master Nov 16, 2024
11 checks passed
@tianon tianon deleted the 4.1-rc branch November 16, 2024 00:52
@tianon
Copy link
Member

tianon commented Nov 16, 2024

Will do! As always, we appreciate the help/engagement 😄

docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Nov 16, 2024
Changes:

- docker-library/rabbitmq@5aeb28e: Merge pull request docker-library/rabbitmq#738 from infosiftr/4.1-rc
- docker-library/rabbitmq@c0dcc40: Add `4.1.0-beta.1` pre-release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Time to add a 4.1.x version of the image :) When to switch to Erlang 27
3 participants