Remove inaccurate references to corruption, remove SEGTERM suggestion… #1303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, update information links to current docs. Postgres is carefully designed such that data is not corrupted on crashes or unclean shutdowns - the main tradeoff is that WAL replay is needed on startup. In practice, SIGTERM can cause unexpected long delays to shutdowns - often during maintenance windows - so best not to activaly suggest this. The links back to official Postgres documentation seem sufficient.
|
Normally I'm not a fan of links with We need to apply this template change to all the variants, but I'm happy to push that change for you, if you'd like me to (otherwise this looks good to me). |
|
I'm still new to this repo; I think the last commit applies the change to the variants - did i do it correctly? |
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Jan 9, 2025
Changes: - docker-library/postgres@32b6fcd: Remove inaccurate references to corruption, remove SEGTERM suggestion… (docker-library/postgres#1303) - docker-library/postgres@cb04936: Simplify and update `verify-templating.yml`
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Jan 24, 2025
Changes: - docker-library/postgres@e2a4302: Update 12 to bookworm 12.22-2.pgdg120+1, bullseye 12.22-2.pgdg110+1 - docker-library/postgres@32b6fcd: Remove inaccurate references to corruption, remove SEGTERM suggestion… (docker-library/postgres#1303) - docker-library/postgres@cb04936: Simplify and update `verify-templating.yml`
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Feb 4, 2025
Changes: - docker-library/postgres@3521b2f: Merge pull request docker-library/postgres#1312 from infosiftr/eol-12 - docker-library/postgres@042d8d0: Remove PostgreSQL 12 since it is end of life - docker-library/postgres@e2a4302: Update 12 to bookworm 12.22-2.pgdg120+1, bullseye 12.22-2.pgdg110+1 - docker-library/postgres@32b6fcd: Remove inaccurate references to corruption, remove SEGTERM suggestion… (docker-library/postgres#1303) - docker-library/postgres@cb04936: Simplify and update `verify-templating.yml`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove inaccurate references to corruption, remove SEGTERM suggestion, update information links to current docs.
Postgres is carefully designed such that data is not corrupted on crashes or unclean shutdowns - the main tradeoff is that WAL replay is needed on startup.
On the SIGTERM suggestion - in practice this can cause unexpected long delays to shutdowns - often during maintenance windows - so best not to actively suggest this. The links back to official Postgres documentation seem sufficient.