Add PHP 8.5 RC #1589
Add PHP 8.5 RC #1589
Conversation
|
@jnoordsij Could you retry the failed job ? |
I don't have any permissions to do so, but also I think it should be fine as it is a clear false negative regarding an unchanged image. This PR is currently (as listed in the description) awaiting the official release announcement. |
|
Yeah, it'll need to be updated once the release comes which will re-trigger everything anyhow 👍 |
| @@ -516,7 +524,7 @@ RUN set -eux; \ | |||
|
|
|||
| COPY docker-php-ext-* docker-php-entrypoint /usr/local/bin/ | |||
|
|
|||
| {{ if IN(rcVersion; "8.1", "8.2", "8.3", "8.4") then ( -}} | |||
| {{ if IN(rcVersion; "8.1", "8.2", "8.3", "8.4", "8.5") then ( -}} | |||
There was a problem hiding this comment.
I don't love this bit (it makes me think we merged #1587 a bit prematurely; we should've waited until it was at least merged/enabled in upstream's development branch), but it is what it is at this point. ❤️
|
@tianon I won't be able to rebase this today, so feel free to finish this if you want to! |
|
Hi @jnoordsij Rebase PR |
|
Thanks for your efforts @thecaliskan. I saw there were some duplicated commits in your PR, probably due to some merging after rebasing. So I've just rebased here so that everything should be all set now. |
|
Thanks! |
Changes: - docker-library/php@adcc38eb: Merge pull request docker-library/php#1589 from jnoordsij/add-php8.5-rc - docker-library/php@5edcb5b2: Add PHP 8.5-rc variant - docker-library/php@6fb46669: Enable OPCache for 8.5 pending upstream changes - docker-library/php@105bb3e5: Update in preparation for first PHP 8.5 alpha release - docker-library/php@c071029e: Update API url for obtaining RC releases - docker-library/php@82bac8f9: Cleanup some (now) unused code/conditions
Modeled after #1526
Note the last commit should be the result of the bot when the QA releases page is updated, but I manually added it to test image builds a little ahead.
This means we should probably watch
https://github.com/php/web-qa/commits/masterhttps://github.com/php/web-php/blob/master/include/release-qa.php for the official release announcement before merging.This also changes the API url used for fetching RC releases, which have been moved towards the 'main' site, with the old one now redirecting towards this new source (see also php/web-php#1261).