-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update library/liquibase to 4.31.0 #18311
Conversation
This comment has been minimized.
This comment has been minimized.
It's not ideal to do such change not on a version bump |
Hi @LaurentGoderre , I agree, but in this case we found the bug after the liquibase 4.31.0 binary went out and we try to stay in sync with the version number. Can we make this exception? It has been tested and approved by our QA team. |
I think the Dockerfile diffs are reasonable. 👍 Can you clean up your branch by doing a rebase on Some helpful links:
|
This comment has been minimized.
This comment has been minimized.
Diff for 2494a97:diff --git a/_bashbrew-cat b/_bashbrew-cat
index 2d1b2ca..e43a833 100644
--- a/_bashbrew-cat
+++ b/_bashbrew-cat
@@ -4,9 +4,9 @@ GitRepo: https://github.com/liquibase/docker.git
Tags: 4.31, 4.31.0, latest
GitFetch: refs/heads/main
-GitCommit: ff5441b137e517f983ab09869f3b1a956f0c839a
+GitCommit: e348326855672a5d20d1789cfdab1ac8b2a6afa2
Tags: 4.31-alpine, 4.31.0-alpine, alpine
GitFetch: refs/heads/main
-GitCommit: ff5441b137e517f983ab09869f3b1a956f0c839a
+GitCommit: e348326855672a5d20d1789cfdab1ac8b2a6afa2
File: Dockerfile.alpine
diff --git a/liquibase_alpine/Dockerfile.alpine b/liquibase_alpine/Dockerfile.alpine
index d6c1368..f491bf4 100644
--- a/liquibase_alpine/Dockerfile.alpine
+++ b/liquibase_alpine/Dockerfile.alpine
@@ -1,10 +1,10 @@
# Use multi-stage build
-FROM alpine:3.20
+FROM alpine:3.21
# Create liquibase user
RUN addgroup --gid 1001 liquibase && \
- adduser --disabled-password --uid 1001 --ingroup liquibase liquibase && \
- mkdir /liquibase && chown liquibase /liquibase
+ adduser --disabled-password --uid 1001 --ingroup liquibase --home /liquibase liquibase && \
+ chown liquibase /liquibase
# Install smaller JRE, if available and acceptable
RUN apk add --no-cache openjdk17-jre-headless bash
diff --git a/liquibase_latest/Dockerfile b/liquibase_latest/Dockerfile
index 25c1e98..19d19b0 100644
--- a/liquibase_latest/Dockerfile
+++ b/liquibase_latest/Dockerfile
@@ -3,8 +3,8 @@ FROM eclipse-temurin:17-jre-jammy
# Create liquibase user
RUN groupadd --gid 1001 liquibase && \
- useradd --uid 1001 --gid liquibase liquibase && \
- mkdir /liquibase && chown liquibase /liquibase
+ useradd --uid 1001 --gid liquibase --create-home --home-dir /liquibase liquibase && \
+ chown liquibase /liquibase
# Install necessary dependencies
#RUN apt-get update && \ Relevant Maintainers:
|
@sayaliM0412 rebased this. Does it look okay now @LaurentGoderre @yosifkit ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sayaliM0412 rebased this. Does it look okay now @LaurentGoderre @yosifkit ?
Yes, LGTM!
Update library/liquibase with latest commit and version