Add "tip" version #531
Add "tip" version #531
Conversation
| @@ -111,8 +111,6 @@ for version; do | |||
|
|
|||
| fullVersion="$(jq -r '.[env.version].version' versions.json)" | |||
|
|
|||
| [[ "$fullVersion" == *.*[^0-9]* ]] || fullVersion+='.0' | |||
There was a problem hiding this comment.
This change is technically valid even without this PR, but it's currently harmless (however with it in this PR, we end up with tags like tip-YYYYMMDD.0, which is undesirable).
| @@ -159,7 +242,7 @@ for version in "${versions[@]}"; do | |||
| "3.19", | |||
| empty | |||
| | "alpine" + .), | |||
| if .arches | has("windows-amd64") and .["windows-amd64"].url then | |||
| if .arches | has("windows-amd64") and .["windows-amd64"].url then # TODO consider windows + tip | |||
There was a problem hiding this comment.
It's technically very doable for us to implement Windows support, but this was enough that I didn't want to get too much deeper and decided to leave Windows as a TODO for now instead.
$ diff -u <(bashbrew cat golang) <(bashbrew cat <(./generate-stackbrew-library.sh))
--- /dev/fd/63 2024-08-15 16:35:29.584348497 -0700
+++ /dev/fd/62 2024-08-15 16:35:29.584348497 -0700
@@ -2,6 +2,27 @@
GitRepo: https://github.com/docker-library/golang.git
Builder: buildkit
+Tags: tip-20240810-bookworm, tip-bookworm
+SharedTags: tip-20240810, tip
+Architectures: amd64, arm32v5, arm32v7, arm64v8, i386, mips64le, ppc64le, s390x
+GitCommit: 819b7657d7783ea8b838ad2497af40f785119ccb
+Directory: tip/bookworm
+
+Tags: tip-20240810-bullseye, tip-bullseye
+Architectures: amd64, arm32v5, arm32v7, arm64v8, i386, mips64le, ppc64le, s390x
+GitCommit: 819b7657d7783ea8b838ad2497af40f785119ccb
+Directory: tip/bullseye
+
+Tags: tip-20240810-alpine3.20, tip-alpine3.20, tip-20240810-alpine, tip-alpine
+Architectures: amd64, arm32v6, arm32v7, arm64v8, i386, ppc64le, riscv64, s390x
+GitCommit: 819b7657d7783ea8b838ad2497af40f785119ccb
+Directory: tip/alpine3.20
+
+Tags: tip-20240810-alpine3.19, tip-alpine3.19
+Architectures: amd64, arm32v6, arm32v7, arm64v8, i386, ppc64le, s390x
+GitCommit: 819b7657d7783ea8b838ad2497af40f785119ccb
+Directory: tip/alpine3.19
+
Tags: 1.23.0-bookworm, 1.23-bookworm, 1-bookworm, bookworm
SharedTags: 1.23.0, 1.23, 1, latest
Architectures: amd64, arm32v7, arm64v8, i386, mips64le, ppc64le, s390x |
This is pinned to the latest commit merged upstream before midnight (UTC) on Monday of the current week.
|
With that last push, this should be fully good for review / consideration now. 👀 |
| @@ -1178,7 +1178,7 @@ | |||
| "src": { | |||
| "url": "https://dl.google.com/go/go1.24rc2.src.tar.gz", | |||
| "sha256": "ba07b6863f208160e8f09f11c8b9582729b51cfeb752ce6ba79a379b4fbcac6d", | |||
| "supported": true | |||
| "supported": false | |||
There was a problem hiding this comment.
Yeah, see https://github.com/docker-library/golang/pull/531/files#diff-75ae6e7f38ff53b3bddf05c7161672455ae64dfc0de8be7566925506498f8a78R205-R213 where I modified the calculation for supported -- the justification in my head at the time I wrote that is that setting this to false for src is more accurate since we don't build from source anywhere anymore, which didn't matter in practice until I added tip support again, where it also doesn't arguably matter either, but I left the field for completeness and decided to make the value more correct anyhow. 😄
This is pinned to the latest commit merged upstream before midnight (UTC) on Monday of the current week (#464 (comment), https://github.com/docker-library/faq#can-i-use-a-bot-to-make-my-image-update-prs).
Closes #464
(Includes/based on #530)