Repository navigation
Conversation
- README: docs/integrations.md covers agent frameworks, workflow
platforms and AWS, not backend setup (that is in getting-started.md).
- architecture.md: Route 53 rejects the RFC 9460 generic keyNNNNN form
too ("InvalidChangeBatch: SVCB does not support undefined
parameters"). Describe what the code does instead: custom parameters
move to the TXT record as dnsaid_keyNNNNN=value (base.py).
- getting-started.md: the "Zone not found" tip suggested setting
AWS_DEFAULT_REGION. Route 53 is global, and the backend reads
AWS_REGION (route53.py:77), so point at the AWS account instead.
- base.py: the comment said the walkable AliasMode record is published
by default. It is off by default (models.py, publisher.py, the CLI's
--walkable); fix the comment only, no code change.
- CONTRIBUTING.md: the main-protection ruleset requires 9 checks; add
the missing Mock Integration Tests row.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Tim Fraser <124688+tefraz@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Five small corrections where the docs (and one code comment) disagree with what the code or Route 53 actually does. No behaviour changes.
README.mddocs/integrations.mdcovers: agent frameworks, workflow platforms and AWSdocs/getting-started.mddocs/architecture.mdkeyNNNNNformkeyNNNNNtoo, so dns-aid-core moves custom parameters to the TXT record asdnsaid_keyNNNNN=valueInvalidChangeBatch: [SVCB does not support undefined parameters.]for akey65402value (details in #247); demotion isbase.py:317docs/getting-started.mdAWS_DEFAULT_REGION=us-east-1AWS_REGION, notAWS_DEFAULT_REGION(route53.py:77)src/dns_aid/backends/base.pypublish_walkable_alias=Trueor--walkablemodels.py:722(default=False),publisher.py:112, CLI help "Off by default"CONTRIBUTING.mdmain-protectionruleset lists 9 required status checksThe
base.pychange is to a comment only.Type of Change
Checklist
pytest)ruff checkandruff format --checkwith no errorsmypy src/with no errorsSigned-off-byline (DCO)Run locally on the branch: unit tests on Python 3.11, 3.12 and 3.13 (2893 passed, 2 skipped, coverage 92.96%), mock integration tests (30 passed), ruff, mypy and Bandit all clean.
Dependency Audit will fail, unrelated to this PR.
pip-auditon currentmainreports vulnerabilities inpyjwt2.13.0 andmcp1.28.1, and the Dependency Audit job has been failing on other PRs since at least 15 October. I've left that alone here so this PR stays docs-only.Related Issues
Relates to #247 (the Route 53
keyNNNNNrejection was found while confirming it).I used Claude Code to help find and verify these and to draft this PR.