Repository navigation
chore(ci): clean up Dependabot config and transfer CODEOWNERS to @nicknacnic - #269
nicknacnic wants to merge 4 commits into
Conversation
|
Reviewed while unblocking First, a correction to something I initially flagged and was wrong about. I read the as widening the Three things I do think are worth addressing: 1. The 2. The PR does more than the title says. "clean up Dependabot config and transfer CODEOWNERS" doesn't signal a dependency bump for two CVEs or a lock resync. On a repo where 3. CODEOWNERS will disagree with the governance docs. This makes Minor: the |
IngmarVG-IB
left a comment
There was a problem hiding this comment.
Approving. Two of my earlier concerns have resolved themselves and I want the record straight:
- The
mcp<2.0.0→<3.0.0hunk was not a widening —pyproject.tomlalready declared<3.0.0anduv.lock'srequires-distwas stale. This was a correct resync. My original reading was wrong. - Removing the
labels: [dependencies, automated]blocks is a fix, not just cleanup: Dependabot has been posting "The following labels could not be found:automated,dependencies. Please create them before Dependabot can add them" on its PRs (visible on #266 since 2026-09-17). Dropping the config resolves that. Worth saying so in the description. - The lock-only
anyiobump is moot now — #271 landed an explicitanyio>=4.14.2floor on the coredependencies(httpxpulls it, so the base install was affected, not just[mcp]). Standing note for next time: a lock-only security bump doesn't hold, since any later re-resolve can drop back below the patched version.
Adding pyproject.toml and uv.lock to CODEOWNERS so pip bumps reach the same reviewer pair as .github/ bumps is a good call.
One item still genuinely open, not a blocker: this makes @nicknacnic catchall owner and drops @iracic82 from every path, but MAINTAINERS.md and GOVERNANCE.md aren't touched — after this merges they'll describe the previous ownership. Please follow up so there's one source of truth on who maintains what.
…knacnic Supersedes dns-aid#124 (Ingmar's config cleanup) with maintainer handover applied in the same commit. Dependabot changes (identical to dns-aid#124): - Rename group patch-security → patches (name was misleading; behavior unchanged) - Add explicit open-pull-requests-limit: 5 to github-actions block (was the default) - Drop reviewers: field (GitHub removed it 2025-08-08; CODEOWNERS is canonical replacement) - Drop unused dependencies/automated labels CODEOWNERS changes: - Replace @iracic82 with @nicknacnic across all entries (maintainer handover) - Add pyproject.toml and uv.lock routing to @nicknacnic @ivanglabbeek so Dependabot pip bumps surface to both maintainers (supply-chain hardening, mirrors the github-actions reviewer pair) Signed-off-by: Layer8 <NWillAU900@gmail.com>
…6-64847 Signed-off-by: Layer8 <NWillAU900@gmail.com>
…tters table Replace @iracic82 with @nicknacnic as Project Lead and add @IngmarVG-IB as Committer, consistent with the CODEOWNERS and MAINTAINERS.md changes in this branch. Signed-off-by: Layer8 <NWillAU900@gmail.com>
Promote @nicknacnic to Project Lead, update @IngmarVG-IB to Committer, and remove @iracic82 — consistent with CODEOWNERS and GOVERNANCE.md on this branch. Adjust maintainer count (3→2) in sustainability section and branch-protection note. Signed-off-by: Layer8 <NWillAU900@gmail.com>
14a7cc4 to
8719eee
Compare
Supersedes #124 — Ingmar's Dependabot cleanup rebased with maintainer handover applied in the same commit.
Dependabot changes (identical to #124)
patch-security→patches(rule covers all patches, not security-only)open-pull-requests-limit: 5togithub-actionsblock (was the implicit default)reviewers:field (GitHub removed it 2025-08-08; CODEOWNERS is the canonical replacement)labels: [dependencies, automated]from both ecosystems — relying on Dependabot's defaultdependencieslabel. Anything filtering on theautomatedlabel will stop matching; this is intentional.CODEOWNERS changes
@iracic82with@nicknacnicacross all entries (maintainer handover)pyproject.tomlanduv.lockrouting to@nicknacnic @ivanglabbeek— Dependabot pip bumps now surface to both maintainers, matching the github-actions reviewer pair (supply-chain hardening)Governance docs
GOVERNANCE.mdCommitters table updated:@nicknacnicas Project Lead,@IngmarVG-IBas Committer — consistent with CODEOWNERS and MAINTAINERS.mdLock resync note
The
uv.lockhunk movinganyioto 4.15.1 was a pre-existing lock/manifest drift correction, not a new bump introduced by this PR. The explicit floor (anyio>=4.14.2) was landed separately in #271 onpyproject.toml; the lock-only change here may be a no-op after rebase.Closes #124