Skip to content

Commit

Permalink
Rename: RunningRecordRequest -> RunningRecordRequestV1으로 클래스명 변경
Browse files Browse the repository at this point in the history
  • Loading branch information
hee9841 committed Dec 19, 2024
1 parent 56a5410 commit db65112
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 14 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
import com.dnd.runus.domain.running.RunningRecordRepository;
import com.dnd.runus.global.exception.NotFoundException;
import com.dnd.runus.presentation.v1.running.dto.WeeklyRunningRatingDto;
import com.dnd.runus.presentation.v1.running.dto.request.RunningRecordRequest;
import com.dnd.runus.presentation.v1.running.dto.request.RunningRecordRequestV1;
import com.dnd.runus.presentation.v1.running.dto.request.RunningRecordWeeklySummaryType;
import com.dnd.runus.presentation.v1.running.dto.response.*;
import org.springframework.beans.factory.annotation.Value;
Expand Down Expand Up @@ -181,7 +181,7 @@ public RunningRecordMonthlySummaryResponse getMonthlyRunningSummery(long memberI
}

@Transactional
public RunningRecordAddResultResponseV1 addRunningRecordV1(long memberId, RunningRecordRequest request) {
public RunningRecordAddResultResponseV1 addRunningRecordV1(long memberId, RunningRecordRequestV1 request) {
Member member =
memberRepository.findById(memberId).orElseThrow(() -> new NotFoundException(Member.class, memberId));

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
import com.dnd.runus.global.exception.type.ErrorType;
import com.dnd.runus.presentation.annotation.MemberId;
import com.dnd.runus.presentation.v1.member.dto.response.MyProfileResponse;
import com.dnd.runus.presentation.v1.running.dto.request.RunningRecordRequest;
import com.dnd.runus.presentation.v1.running.dto.request.RunningRecordRequestV1;
import com.dnd.runus.presentation.v1.running.dto.request.RunningRecordWeeklySummaryType;
import com.dnd.runus.presentation.v1.running.dto.response.*;
import io.swagger.v3.oas.annotations.Operation;
Expand Down Expand Up @@ -67,7 +67,7 @@ public RunningRecordSummaryResponse getRunningRecordSummaries(
@PostMapping
@ResponseStatus(HttpStatus.OK)
public RunningRecordAddResultResponseV1 addRunningRecord(
@MemberId long memberId, @Valid @RequestBody RunningRecordRequest request) {
@MemberId long memberId, @Valid @RequestBody RunningRecordRequestV1 request) {
return runningRecordService.addRunningRecordV1(memberId, request);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

import java.time.LocalDateTime;

public record RunningRecordRequest(
public record RunningRecordRequestV1(
@NotNull
LocalDateTime startAt,
@NotNull
Expand All @@ -36,7 +36,7 @@ public record RunningRecordRequest(
@NotNull
RunningRecordMetricsForAddDto runningData
) {
public RunningRecordRequest {
public RunningRecordRequestV1 {
if (startAt.isAfter(endAt)) {
throw new BusinessException(ErrorType.START_AFTER_END, startAt + " ~ " + endAt);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
import com.dnd.runus.presentation.v1.running.dto.RunningRecordMetricsForAddDto;
import com.dnd.runus.presentation.v1.running.dto.WeeklyRunningRatingDto;
import com.dnd.runus.presentation.v1.running.dto.request.RunningAchievementMode;
import com.dnd.runus.presentation.v1.running.dto.request.RunningRecordRequest;
import com.dnd.runus.presentation.v1.running.dto.request.RunningRecordRequestV1;
import com.dnd.runus.presentation.v1.running.dto.request.RunningRecordWeeklySummaryType;
import com.dnd.runus.presentation.v1.running.dto.response.RunningRecordAddResultResponseV1;
import com.dnd.runus.presentation.v1.running.dto.response.RunningRecordMonthlySummaryResponse;
Expand Down Expand Up @@ -188,7 +188,7 @@ void getRunningRecord_challenge() {
@DisplayName("CHALLENGE 모드의 러닝 기록 추가 요청시, challengeId에 해당하는 챌린지가 있을 경우, 정상적으로 러닝 기록이 추가된다.")
void addRunningRecord_challenge() {
// given
RunningRecordRequest request = new RunningRecordRequest(
RunningRecordRequestV1 request = new RunningRecordRequestV1(
LocalDateTime.of(2021, 1, 1, 12, 10, 30),
LocalDateTime.of(2021, 1, 1, 13, 12, 10),
"start location",
Expand Down Expand Up @@ -228,7 +228,7 @@ void addRunningRecord_challenge() {
@DisplayName("GOAL 모드의 러닝 기록 추가 시,goalTime이 null이 아니고 목표값보다 실제값이 더 크다면, 성공한 goalAchievement와 함께 정상적으로 러닝 기록이 추가된다.")
void addRunningRecord_goal_time_success() {
// given
RunningRecordRequest request = new RunningRecordRequest(
RunningRecordRequestV1 request = new RunningRecordRequestV1(
LocalDateTime.of(2021, 1, 1, 12, 10, 30),
LocalDateTime.of(2021, 1, 1, 13, 12, 10),
"start location",
Expand Down Expand Up @@ -267,7 +267,7 @@ void addRunningRecord_goal_time_success() {
"GOAL 모드의 러닝 기록 추가 시, goalTime이 null이 아니고 목표값보다 실제값이 더 낮다면, 실패한 goalAchievement와 함께 정상적으로 러닝 기록이 추가된다.")
void addRunningRecord_goal_time_fail() {
// given
RunningRecordRequest request = new RunningRecordRequest(
RunningRecordRequestV1 request = new RunningRecordRequestV1(
LocalDateTime.of(2021, 1, 1, 12, 10, 30),
LocalDateTime.of(2021, 1, 1, 13, 12, 10),
"start location",
Expand Down Expand Up @@ -306,7 +306,7 @@ void addRunningRecord_goal_time_fail() {
"GOAL 모드의 러닝 기록 추가 요청시, goalDistance가 null이 아니고 목표값보다 실제값이 더 높다면 성공한 goalAchievement와 함께 정상적으로 러닝 기록이 추가된다.")
void addRunningRecord_goal_distance() {
// given
RunningRecordRequest request = new RunningRecordRequest(
RunningRecordRequestV1 request = new RunningRecordRequestV1(
LocalDateTime.of(2021, 1, 1, 12, 10, 30),
LocalDateTime.of(2021, 1, 1, 13, 12, 10),
"start location",
Expand Down Expand Up @@ -345,7 +345,7 @@ void addRunningRecord_goal_distance() {
"GOAL 모드의 러닝 기록 추가 요청시, goalDistance가 null이 아니고 목표값보다 실제값과 같다면 성공한 goalAchievement와 함께 정상적으로 러닝 기록이 추가된다.")
void addRunningRecord_goal_distance_same_value() {
// given
RunningRecordRequest request = new RunningRecordRequest(
RunningRecordRequestV1 request = new RunningRecordRequestV1(
LocalDateTime.of(2021, 1, 1, 12, 10, 30),
LocalDateTime.of(2021, 1, 1, 13, 12, 10),
"start location",
Expand Down Expand Up @@ -383,7 +383,7 @@ void addRunningRecord_goal_distance_same_value() {
@DisplayName("러닝의 페이스가 올바르게 계산되었는지 확인한다.")
void addRunningRecord_check_cal_pace() {
// given
RunningRecordRequest request = new RunningRecordRequest(
RunningRecordRequestV1 request = new RunningRecordRequestV1(
LocalDateTime.of(2021, 1, 1, 12, 10, 30),
LocalDateTime.of(2021, 1, 1, 13, 12, 10),
"start location",
Expand Down Expand Up @@ -502,7 +502,7 @@ void getWeeklySummary_Duration() {
assertThat(response.lastWeekAvgValue()).isEqualTo(expectedRunningDurationHour);
}

private RunningRecord createRunningRecord(RunningRecordRequest request, Member member) {
private RunningRecord createRunningRecord(RunningRecordRequestV1 request, Member member) {

return RunningRecord.builder()
.member(member)
Expand Down

0 comments on commit db65112

Please sign in to comment.