Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove extra files from TW tarballs #8718

Merged
merged 3 commits into from
Sep 30, 2024
Merged

Remove extra files from TW tarballs #8718

merged 3 commits into from
Sep 30, 2024

Conversation

belforte
Copy link
Member

initial step to simplify TW tarballs handling as per #8699

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Pylint check: failed
    • 36 warnings and errors that must be fixed
    • 1 warnings
    • 403 comments to review
  • Pycodestyle check: succeeded
    • 580 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-CRABServer-PR-test/2178/artifact/artifacts/PullRequestReport.html

@belforte
Copy link
Member Author

about pylint: all the errors come from cmscp.py. I am not going to touch it until/unless we have a need to change or decide to rewrite !!

@belforte belforte mentioned this pull request Sep 26, 2024
Closed
novicecpp
novicecpp approved these changes Sep 30, 2024
View reviewed changes
scripts/cmscp.py Show resolved Hide resolved
@belforte belforte merged commit 88f8351 into dmwm:master Sep 30, 2024
1 of 2 checks passed
@belforte belforte deleted the remove-extra-files-from-tarballs branch September 30, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@novicecpp novicecpp novicecpp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@belforte @cmsdmwmbot @novicecpp